ts) jsx-constructor properties

knockout · Jan 30, 2025 · 2127388 · 2127388
1 parent 83c2337
commit 2127388
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/binding.component/spec/componentBindingBehaviors.ts b/packages/binding.component/spec/componentBindingBehaviors.ts
@@ -1297,7 +1297,7 @@ describe('Components: Component binding', function () {
           }]
         }]
       }
-      new JsxObserver(jsx, testNode, null, null, null)
+      new JsxObserver(jsx, testNode)
 
       class ViewModel extends components.ComponentABC {
         static get template () {
@@ -1355,7 +1355,7 @@ describe('Components: Component binding', function () {
         }]
       }
 
-      new JsxObserver(jsx, testNode, null, null, null)
+      new JsxObserver(jsx, testNode)
 
       class ViewModel extends components.ComponentABC {
         static get template () {
@@ -1406,7 +1406,7 @@ describe('Components: Component binding', function () {
         }]
       }
 
-      const jo = new JsxObserver(jsx, testNode, null, null, null)
+      const jo = new JsxObserver(jsx, testNode)
 
       class ViewModel extends components.ComponentABC {
         static get template () {

diff --git a/packages/utils.jsx/src/JsxObserver.ts b/packages/utils.jsx/src/JsxObserver.ts
@@ -76,7 +76,7 @@ export class JsxObserver extends LifeCycle {
   /**
    * @param {any} jsxOrObservable take a long list of permutations
    */
-  constructor (jsxOrObservable: any, parentNode:Node, insertBefore:Node | null = null, xmlns: any, noInitialBinding?: boolean | null) {
+  constructor (jsxOrObservable: any, parentNode:Node, insertBefore:Node | null = null, xmlns?: any, noInitialBinding?: boolean | null) {
     super()
 
     const parentNodeIsComment = parentNode.nodeType === 8