Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add insecure registry configuration to containerd when using registry flag; refs #555 #556

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MatthewHehir
Copy link

Changes

Unable to pull images from local registry created with --registry

  • Adds the missing configuration required to pull images from the local registry iff using the --registry flag.

/kind bug

Fixes #555

Release Note

Kind is now able to pull images from the local registry created using the `--registry` flag.

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 3, 2024
Copy link

CLA Not Signed

Copy link

knative-prow bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MatthewHehir
Once this PR has been reviewed and has the lgtm label, please assign davidhadas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from psschwei and rhuss December 3, 2024 12:55
Copy link

knative-prow bot commented Dec 3, 2024

Welcome @MatthewHehir! It looks like this is your first PR to knative-extensions/kn-plugin-quickstart 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 3, 2024
Copy link

knative-prow bot commented Dec 3, 2024

Hi @MatthewHehir. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 3, 2024
@MatthewHehir MatthewHehir marked this pull request as draft December 3, 2024 13:00
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't pull images from local registry
1 participant