Using global variable to control bpf log level #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| config.BpfLogLevel = uint32(level) | ||
| if err := bpf.UpdateKmeshConfigMap(s.kmeshConfigMap, config); err != nil { | ||
| http.Error(w, fmt.Sprintf("update log level error: %v", err), http.StatusBadRequest) | ||
| if err := s.bpfLogLevel.Set(uint32(level)); err != nil { |
There was a problem hiding this comment.
So is it now not necessary for KmeshConfigmap to pass the log_level?
Signed-off-by: Zhonghu Xu <[email protected]>
hzxuzhonghu
force-pushed
the
global-var
branch
from
05db8eb to
e94e27d
Compare
Signed-off-by: Zhonghu Xu <[email protected]>
|
/lgtm |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Using global variable to control bpf log level
Should be after #1205
Which issue(s) this PR fixes:
Fixes #
Special notes for you're reviewer:
Does this PR introduce a user-facing change?: