Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made many enhancements and also closes issue #5 #6

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

nandub
Copy link

@nandub nandub commented Dec 2, 2020

KM4ACK,

Please review my changes and see if you agree with them.

73,
Nando - KI5LKF

@km4ack
Copy link
Owner

km4ack commented Dec 4, 2020

First, thanks for the help on this. Networking isn't my strong suit and I haven't worked on this script or the new version in quite a while. I don't know how much time I can dedicate to this during December. I have family that drifts in and out of town during the holiday season. If you can explain the things below, I will go ahead and merge to the dev branch for now and test over the coming weeks.

  1. What is the difference between these two line?
    sudo echo "nohook wpa_supplicant" >> /etc/dhcpcd.conf
    sudo su -c 'echo "nohook wpa_supplicant" >> /etc/dhcpcd.conf'

  2. Not sure about this change. Maybe I am missing something.
    CIP=$(ip address show dev wlan0 | grep -v inet6 | grep inet | awk '{ print $2 }' | sed 's//24//')
    One of my pi's returns the correct address in hotspot mode (10.10.10.10). The other isn't in hotspot mode and returns 10.163.254.205/28
    I believe it should return 10.163.254.205. Mod the last sed?

73, de KM4ACK

@nandub
Copy link
Author

nandub commented Dec 10, 2020

You very welcome. Thanks for the feedback. I will make the changes based on your feedback below for no 2.

1- What is the difference between these two line?
sudo echo "nohook wpa_supplicant" >> /etc/dhcpcd.conf
^^ this line fails on my rpi2 with: bash: /etc/dhcpcd.conf: Permission denied
sudo su -c 'echo "nohook wpa_supplicant" >> /etc/dhcpcd.conf'
^^ however this work succeeds. I cannot remember the website that showed me this trick though.

2- Not sure about this change. Maybe I am missing something.
CIP=$(ip address show dev wlan0 | grep -v inet6 | grep inet | awk '{ print $2 }' | sed 's//24//')
One of my pi's returns the correct address in hotspot mode (10.10.10.10). The other isn't in hotspot mode and returns 10.163.254.205/28
I believe it should return 10.163.254.205. Mod the last sed?
^^ I guess I miss 28. I will change the code to cover 28.

73, de KI5LKF

@nandub
Copy link
Author

nandub commented Dec 25, 2020

@km4ack I made the changes suggested by another user, but lost track of who after making the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants