Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/design logs n metrics #84

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

abdheshnayak
Copy link
Member

No description provided.

@abdheshnayak abdheshnayak merged commit b9ba97d into release-v1.0.2 Feb 8, 2024
2 of 4 checks passed
@abdheshnayak abdheshnayak deleted the improve/design-logs-n-metrics branch February 8, 2024 15:32
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request introduces a significant enhancement to the logging and metrics visualization within the console application. It consolidates logs and metrics into a unified view, improving the user experience by allowing for easier correlation between system behavior and log events. The changes include the addition of a new route for logs and metrics, the integration of a logging context provider, and updates to various components to support the new functionality. Additionally, the PR includes improvements to the code view component, enabling syntax highlighting and better presentation of code snippets.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
  • Files deleted: Sourcery does not currently approve diffs with deleted files.
  • Big diff: the diff is too large to approve with confidence.

General suggestions:

  • Ensure that the new logging and metrics functionality is thoroughly tested, especially the WebSocket connections and the dynamic rendering of logs and metrics data.
  • Consider adding more detailed comments to the newly introduced functions and components, explaining their purpose and how they fit into the overall architecture of the application.
  • Review the accessibility of the new UI components to ensure that they are accessible to all users, including those using screen readers or keyboard navigation.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

abdheshnayak added a commit that referenced this pull request Oct 28, 2024
* 🎨 Improved design for logs component

improved design for logs and disabled network_io and disk_io for apps

* 🔖 Updated build

* 🔖 Updated build

* 🔖 Build update

* 🔖 Build update

* 🎨 Improved logs

* 🎨 Logs improved
tulsiojha pushed a commit that referenced this pull request Nov 1, 2024
* 🎨 Improved design for logs component

improved design for logs and disabled network_io and disk_io for apps

* 🔖 Updated build

* 🔖 Updated build

* 🔖 Build update

* 🔖 Build update

* 🎨 Improved logs

* 🎨 Logs improved
abdheshnayak added a commit that referenced this pull request Nov 5, 2024
* 🎨 Improved design for logs component

improved design for logs and disabled network_io and disk_io for apps

* 🔖 Updated build

* 🔖 Updated build

* 🔖 Build update

* 🔖 Build update

* 🎨 Improved logs

* 🎨 Logs improved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant