Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Cli queries updated #74

Merged
merged 1 commit into from
Jan 26, 2024
Merged

🎨 Cli queries updated #74

merged 1 commit into from
Jan 26, 2024

Conversation

abdheshnayak
Copy link
Member

No description provided.

@abdheshnayak abdheshnayak merged commit 86a0b0e into release-1.0.5 Jan 26, 2024
1 of 2 checks passed
Copy link

Pull Request Report

Hey there! I've prepared a report for the pull request. Let's dive in!

Changes

  1. Renamed cli_coreUpdateDevicePorts to cli_updateDevicePorts in device-queries.ts (line 32).
  2. Renamed cli_coreUpdateDeviceEnv to cli_updateDeviceEnv in device-queries.ts (line 46).
  3. Renamed cli_listCoreDevices to cli_listDevices in device-queries.ts (line 66).
  4. Renamed cli_getCoreDevice to cli_getDevice in device-queries.ts (line 104).
  5. Renamed cli_createCoreDevice to cli_createDevice in device-queries.ts (line 134).

Suggestions

  1. Consider using more descriptive names for the variables and functions to improve code readability.

Bugs

No bugs found.

Improvements

No improvements found.

Rating

I would rate the code as follows:

  • Readability: 8/10
  • Performance: 9/10
  • Security: 9/10

Great job overall!

That's it for the report. Let me know if you need any further assistance. Happy coding!

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Refactoring

PR Summary: The pull request consists of a series of renamings within the GraphQL queries related to VPN devices. The 'core' prefix is being removed from various query and mutation names, streamlining the naming convention across the codebase.

Decision: Comment

📝 Type: 'Refactoring' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that the renaming is consistently applied across the entire codebase to maintain clarity and avoid confusion.
  • Verify that all references to the updated query and mutation names are also updated in client code, documentation, and any other relevant places.
  • Confirm that the removal of cli_updateCoreDevicePorts is intentional and that its functionality is either deprecated or replaced, and that no external dependencies are broken due to this change.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

abdheshnayak added a commit that referenced this pull request Oct 28, 2024
tulsiojha pushed a commit that referenced this pull request Nov 1, 2024
abdheshnayak added a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant