-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed provider server error #70
Conversation
tulsiojha
commented
Jan 24, 2024
- Fixed provider server error
Pull Request ReportHello! Here's the report for the pull request: Changes
Suggestions
Bugs
Improvements
RatingI would rate the code as follows:
That's it for the report! Let me know if you need any further assistance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Bug fix
PR Summary: The pull request addresses an issue with provider server error handling by modifying the logging approach within the authentication route.
Decision: Comment
📝 Type: 'Bug fix' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the change from a structured logger to
console.log
aligns with the application's logging strategy, especially for production environments. - Consider reverting the change if it was intended for temporary debugging purposes to maintain consistency with the existing logging practices.
- If the change to
console.log
is intentional, provide context in the PR description about why this approach is preferred over the existing logger.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
@@ -25,7 +25,8 @@ export const restActions = async (ctx: IRemixCtx) => { | |||
).checkOauthEnabled({}); | |||
|
|||
if (checkError) { | |||
logger.error(checkError); | |||
// logger.error(checkError); | |||
console.log(checkError); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (llm): Replacing a logger call with console.log
is generally not advisable in production code, as it may not adhere to the logging levels and formats defined by the application's logging strategy. If this change is for debugging purposes, it should be reverted before merging.
Fixed provider server error
Fixed provider server error