-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Servicebinding #335
Servicebinding #335
Conversation
Reviewer's Guide by SourceryThis PR implements service host functionality for service bindings. The changes include adding a new 'Service Host' column to display and copy service URLs, updating GraphQL queries to include the serviceHost field, and modifying helm chart file naming. Sequence diagram for copying Service Host URLsequenceDiagram
actor User
participant ListView
participant ServiceView
participant CopyContentToClipboard
User->>ListView: View service list
ListView->>ServiceView: Render serviceHost
ServiceView->>CopyContentToClipboard: Copy service URL
CopyContentToClipboard-->>User: Show toast message
ER diagram for Service Binding with Service HosterDiagram
SERVICE_BINDING {
String serviceHost
}
SERVICE_BINDING ||--o{ SERVICE : "has"
note for SERVICE_BINDING "Added serviceHost field"
Class diagram for Service Binding with Service HostclassDiagram
class IServiceBinding {
+String serviceHost
}
class ListView {
+ListView(items: BaseType[], onAction: function)
}
class ServiceView {
+ServiceView(service: String)
}
class CopyContentToClipboard {
+CopyContentToClipboard(content: String, toastMessage: String)
}
ListView --> IServiceBinding : uses
ListView --> ServiceView : uses
ServiceView --> CopyContentToClipboard : uses
note for IServiceBinding "Added serviceHost attribute"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tulsiojha - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please remove the console.log statement in the parseItem function before merging.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add a 'Service Host' field to the service binding resource view and enhance the 'SettingValues' component to dynamically generate file paths based on Helm chart names.
New Features:
Enhancements: