Env/workload

[tulsiojha]

• added helmcharts
• services bindings

Summary by Sourcery

Refactor the environment layout and service route components to improve code clarity and functionality. Remove unused code and dependencies, and enhance the EnvironmentTabs component to conditionally filter tabs based on environment properties. Update the service route loader to handle redirection based on the presence of a cluster name.

Enhancements:

• Refactor the EnvironmentTabs component to filter tabs based on the presence of a cluster name in the environment.
• Simplify the CurrentBreadcrum component by removing unused code and dependencies.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR implements environment-specific service binding functionality by cleaning up unused code and adding cluster-based service visibility. The changes primarily focus on environment tab management and service binding route handling.

Sequence diagram for service binding route handling

sequenceDiagram
    participant User
    participant UI
    participant Backend
    participant GQLServerHandler

    User->>UI: Access service binding route
    UI->>Backend: Call loader function
    Backend->>GQLServerHandler: getEnvironment(environment)
    GQLServerHandler-->>Backend: Return environment data
    alt Environment has no clusterName
        Backend->>UI: Redirect to environment page
    else Environment has clusterName
        Backend->>GQLServerHandler: listServiceBinding(environment)
        GQLServerHandler-->>Backend: Return service bindings data
        Backend->>UI: Display service bindings
    end

Loading

Updated class diagram for EnvironmentTabs component

classDiagram
    class EnvironmentTabs {
        +EnvironmentTabs(env: IEnvironment)
        +CommonTabs
        -useParams()
        -parseName(env)
    }

    class IEnvironment {
        +String displayName
        +String clusterName
    }

    EnvironmentTabs --> IEnvironment: uses

Loading

File-Level Changes

Change	Details	Files
Refactored environment tabs component to handle cluster-dependent service visibility	Added environment prop to EnvironmentTabs component Implemented conditional filtering of service tabs based on cluster presence Removed commented out code for external apps and jobs/crons tabs	src/apps/console/routes/_main+/$account+/env+/$environment+/_layout.tsx
Enhanced service binding route with environment validation and redirection	Added environment data fetching to validate cluster presence Implemented redirect logic when cluster is not available Updated loader return type to include redirect information	src/apps/console/routes/_main+/$account+/env+/$environment+/services/route.tsx
Code cleanup and optimization	Removed unused commented code sections Removed unused environment search and dropdown functionality Cleaned up type definitions and imports	src/apps/console/routes/_main+/$account+/env+/$environment+/_layout.tsx package-lock.json

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @tulsiojha - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please provide a more detailed PR description explaining the purpose of these changes, what problem they solve, and any important context. This will help reviewers and future maintainers understand the changes better.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (complexity): Consider restructuring the control flow to handle the redirect case immediately after checking conditions

The current implementation introduces unnecessary complexity with the shouldRedirect flag. We can simplify the control flow while maintaining the same functionality:

export const loader = (ctx: IRemixCtx) => {
  const { environment, account } = ctx.params;

  const promise = pWrapper(async () => {
    ensureAccountSet(ctx);

    const { data, errors } = await GQLServerHandler(ctx.request).getEnvironment({
      name: environment,
    });

    if (errors) {
      throw errors[0];
    }

    // Handle redirect case immediately
    if (!data.clusterName) {
      const { data: mData, errors: mErrors } = await GQLServerHandler(
        ctx.request
      ).listServiceBinding({
        envName: environment,
        pagination: getPagination(ctx),
      });

      if (mErrors) {
        throw mErrors[0];
      }

      return { 
        serviceBindingsData: mData, 
        redirect: `/${account}/env/${environment}` 
      };
    }

    // Normal flow without redirect
    const { data: mData, errors: mErrors } = await GQLServerHandler(
      ctx.request
    ).listServiceBinding({
      envName: environment,
      pagination: getPagination(ctx),
    });

    if (mErrors) {
      throw mErrors[0];
    }

    return { serviceBindingsData: mData, redirect: '' };
  });

  return defer({ promise });
}