Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB: update msvc page with annotations #333

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

nxtcoder19
Copy link
Contributor

@nxtcoder19 nxtcoder19 commented Nov 29, 2024

Summary by Sourcery

Enhancements:

  • Add annotations to the managed service settings in the MSVC page.

Copy link

sourcery-ai bot commented Nov 29, 2024

Reviewer's Guide by Sourcery

This PR adds support for annotations in the managed service settings page by updating the form data structure to include annotations from the managed service metadata.

Class diagram for updated managed service settings

classDiagram
    class ManagedService {
        +String displayName
        +String clusterName
        +Boolean isNameError
        +Map annotations
        +Object res
    }
    class Metadata {
        +String name
        +Map annotations
    }
    ManagedService --> Metadata : metadata
    note for ManagedService "Added annotations to ManagedService and Metadata classes"
Loading

File-Level Changes

Change Details Files
Added annotations support in the managed service settings form
  • Added annotations field to the initial form state from managedService metadata
  • Updated form submission data to include annotations in the metadata object
src/apps/console/routes/_main+/$account+/msvc+/$msv+/settings+/general/route.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nxtcoder19 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@nxtcoder19 nxtcoder19 merged commit ba9e129 into release-v1.1.1 Nov 29, 2024
5 checks passed
@nxtcoder19 nxtcoder19 deleted the update/msvc-plugins branch November 29, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant