-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
queries added for env status update #329
Conversation
Reviewer's Guide by SourceryThis PR adds new GraphQL queries and updates existing ones to support environment status updates. The changes primarily involve adding new fields to existing queries and introducing new mutations/queries for environment and BYOK cluster management. Class diagram for updated GraphQL queriesclassDiagram
class cliQueries {
+cli_getEnvironment()
+cli_updateEnvironment()
+cli_cloneEnvironment()
+cli_listEnvironments()
+cli_getBYOKCluster()
+cli_createClusterReference()
}
cliQueries : +isArchived
cliQueries : +suspend
class gql {
+query authCli_getEnvironment()
+mutation authCli_updateEnvironment()
+mutation authCli_cloneEnvironment()
+query authCli_listEnvironments()
+query authCli_getBYOKCluster()
+mutation authCli_createClusterReference()
}
gql : +isArchived
gql : +suspend
note for cliQueries "New fields and queries added for environment and BYOK cluster management"
note for gql "New fields and queries added for environment and BYOK cluster management"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nxtcoder36 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
`, | ||
{ | ||
transformer: (data: any) => data.core_updateEnvironment, | ||
vars(_: any) {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: The vars function should handle the required 'env' parameter for the mutation
The GraphQL mutation requires an 'env' parameter but the vars function isn't processing any inputs. This could cause runtime failures.
Summary by Sourcery
Add new GraphQL operations for updating environment details and retrieving BYOK cluster information, and enhance existing queries with additional fields for improved environment status tracking.
New Features:
Enhancements: