Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed framer-motion from option-list #324

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

tulsiojha
Copy link
Contributor

@tulsiojha tulsiojha commented Oct 15, 2024

Summary by Sourcery

Enhancements:

  • Replace framer-motion animations with custom CSS animations for the OptionMenuContent component.

Copy link

sourcery-ai bot commented Oct 15, 2024

Reviewer's Guide by Sourcery

This pull request removes the framer-motion dependency from the option-list component and replaces it with CSS animations. The changes focus on simplifying the animation implementation and improving performance by using native CSS transitions.

Class diagram for OptionMenuContent component changes

classDiagram
    class OptionMenuContent {
        +ref
        +sideOffset
        +align
        +side
        +alignOffset
        +loop
        +asChild
        +onClick(e)
        +children
    }
    note for OptionMenuContent "Removed framer-motion and added CSS animations"
    class OptionMenuPrimitive {
        +Portal
        +Content
    }
Loading

Class diagram for Tailwind CSS configuration changes

classDiagram
    class TailwindConfig {
        +keyframes
        +animation
    }
    TailwindConfig : +slideDownAndFade
    TailwindConfig : +slideLeftAndFade
    TailwindConfig : +slideUpAndFade
    TailwindConfig : +slideRightAndFade
    note for TailwindConfig "Added new CSS animations for sliding and fading"
Loading

File-Level Changes

Change Details Files
Removed framer-motion animations from OptionMenuContent
  • Removed AnimatePresence component
  • Replaced motion.div with a regular div element
  • Removed initial, animate, exit, and transition props
  • Added CSS classes for animations using Tailwind
src/design-system/components/atoms/option-list.tsx
Added new CSS animations to Tailwind configuration
  • Added slideDownAndFade, slideLeftAndFade, slideUpAndFade, and slideRightAndFade keyframes
  • Added corresponding animation classes with cubic-bezier timing functions
src/design-system/tailwind-base.js
Updated OptionMenuPrimitive.Content props
  • Removed forceMount prop
  • Removed conditional rendering based on 'open' state
src/design-system/components/atoms/option-list.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tulsiojha - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tulsiojha tulsiojha merged commit 73c9e66 into release-v1.0.8 Oct 15, 2024
5 checks passed
@tulsiojha tulsiojha deleted the popup/test branch October 15, 2024 09:00
abdheshnayak pushed a commit that referenced this pull request Oct 28, 2024
removed framer-motion from option-list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant