-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/profile popup #319
Fix/profile popup #319
Conversation
…and fixed react-select issue for disabled option
Reviewer's Guide by SourceryThis pull request focuses on fixing issues related to the profile popup and making minor adjustments to various components. The changes primarily involve code formatting, event handling improvements, and small functional updates across multiple files. User journey diagram for profile popup interactionjourney
title User Journey for Profile Popup Interaction
section Profile Menu Interaction
User -> OptionList.Root: Open Profile Menu
User -> OptionList.Trigger: Click Profile Trigger
OptionList.Trigger -> OptionList.Item: Display Profile Options
User -> OptionList.Item: Click Profile Settings
OptionList.Item -> navigate: Navigate to Profile Settings
section Profile Settings
navigate -> Profile Settings Page: Load Profile Settings Page
User -> Profile Settings Page: Interact with Profile Settings
Class diagram for OptionList componentsclassDiagram
class OptionMenuTrigger {
+forwardRef<HTMLButtonElement, ITrigger>
}
class OptionMenuContent {
+forwardRef
}
class OptionItemRaw {
+forwardRef
}
class OptionMenuItem {
+forwardRef<HTMLDivElement, IOptionMenuItem>
}
class OptionMenuLink {
+forwardRef<HTMLDivElement, IOptionMenuLink>
}
class OptionMenuTextInputItem {
+forwardRef
}
class OptionMenuCheckboxItem {
+forwardRef<HTMLDivElement, IOptionMenuCheckbox>
}
class OptionMenuRadioItem {
+forwardRef<HTMLDivElement, IOptionMenuRadio>
}
class OptionMenuSeparator {
+forwardRef<HTMLDivElement, IOptionMenuSeparator>
}
class OptionMenuTabs {
+forwardRef<HTMLDivElement, IOptionMenuTabs>
}
class Root {
+open: boolean
+setOpen: function
}
OptionMenuTrigger --> OptionMenuContent
OptionMenuContent --> OptionItemRaw
OptionItemRaw --> OptionMenuItem
OptionMenuItem --> OptionMenuLink
OptionMenuLink --> OptionMenuTextInputItem
OptionMenuTextInputItem --> OptionMenuCheckboxItem
OptionMenuCheckboxItem --> OptionMenuRadioItem
OptionMenuRadioItem --> OptionMenuSeparator
OptionMenuSeparator --> OptionMenuTabs
OptionMenuTabs --> Root
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tulsiojha - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
* fixed profile dropdown menu not closing issue, upgraded react-select and fixed react-select issue for disabled option
* fixed profile dropdown menu not closing issue, upgraded react-select and fixed react-select issue for disabled option
* fixed profile dropdown menu not closing issue, upgraded react-select and fixed react-select issue for disabled option
Summary by Sourcery
Fix the profile popup functionality and enhance the handling of disabled states across components. Improve consistency in parameter list formatting and prevent default events in specific components to enhance user interaction.
Bug Fixes:
Enhancements: