-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed issue with user management #313
Conversation
fixed error that occured while removing the user form the team.
Reviewer's Guide by SourceryThis pull request addresses an issue with user management, specifically when removing a user from a team. The changes involve minor code formatting adjustments, updating user identification, modifying a success message, and adding a user ID field to GraphQL queries. ER diagram for updated GraphQL querieserDiagram
USER {
string name
string joined
string email
string id
}
TEAM {
string role
}
USER ||--o{ TEAM : "has role in"
USER ||--o{ ACCOUNT : "is member of"
ACCOUNT {
string accountName
}
Class diagram for UserAccessResources componentclassDiagram
class UserAccessResources {
- showDeleteDialog: BaseType | null
- showUserInvite: BaseType | null
+ reloadPage()
+ handleError(err)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @abdheshnayak - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🐛 Fixed issue with user management
🐛 Fixed issue with user management
🐛 Fixed issue with user management
Summary by Sourcery
Fix the issue with user management by correcting the user ID reference in the team settings and update the success message for resource removal. Add user ID to the GraphQL query for listing memberships.
Bug Fixes:
Enhancements: