Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB: Add sm variant for chip #309

Merged
merged 3 commits into from
Oct 4, 2024
Merged

WEB: Add sm variant for chip #309

merged 3 commits into from
Oct 4, 2024

Conversation

nxtcoder19
Copy link
Contributor

@nxtcoder19 nxtcoder19 commented Oct 3, 2024

Summary by Sourcery

Add a new 'SM' variant to the Chip component for smaller styling options and enhance the ListView component to utilize this new variant for displaying template chips. Adjust the 'Cluster' column in the ListView for consistent styling.

New Features:

  • Introduce a new 'SM' variant for the Chip component, allowing for smaller padding and text styling.

Enhancements:

  • Modify the ListView component to include a 'Cluster' column with a fixed width and flex styling.
  • Update the ListView component to display a 'Template' Chip with the new 'SM' type when the cluster name is empty.

Copy link

sourcery-ai bot commented Oct 3, 2024

Reviewer's Guide by Sourcery

This pull request adds a new 'SM' (small) variant for the Chip component and updates the environment resources list view to use this new variant. The changes primarily affect the styling and layout of the Chip component and its usage in the environment resources list.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a new 'SM' variant to the Chip component
  • Introduced 'SM' as a new ChipType
  • Added conditional styling for the 'SM' variant
  • Implemented size-specific text styling for the 'SM' variant
src/design-system/components/atoms/chips.tsx
Updated the environment resources list view to use the new 'SM' Chip variant
  • Restructured the layout of the list view items
  • Added a Chip component with 'SM' type for template items
  • Adjusted the 'cluster' column styling
src/apps/console/routes/_main+/$account+/environments/environment-resources-v2.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nxtcoder19 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a more descriptive name for the 'SM' chip variant, such as 'SMALL', to improve code readability and maintainability.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@nxtcoder19 nxtcoder19 merged commit 586b7ff into release-v1.0.8 Oct 4, 2024
5 checks passed
@nxtcoder19 nxtcoder19 deleted the ui/changes branch October 4, 2024 10:15
abdheshnayak pushed a commit that referenced this pull request Oct 28, 2024
WEB: Add sm variant for chip
tulsiojha pushed a commit that referenced this pull request Nov 1, 2024
WEB: Add sm variant for chip
abdheshnayak pushed a commit that referenced this pull request Nov 5, 2024
WEB: Add sm variant for chip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant