intercept app cli query updated

[nxtcoder36]

Summary by Sourcery

Introduce a new GraphQL query to fetch DNS host suffix and enhance the existing app interception mutation by renaming it and modifying its parameters to support local cluster interception.

New Features:

• Add a new GraphQL query cli_getDNSHostSuffix to retrieve the DNS host suffix.

Enhancements:

• Update the cli_interceptApp mutation to cli_interceptAppOnLocalCluster, changing parameters from deviceName to clusterName and adding ipAddr.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request updates the CLI query for intercepting an app, introduces a new query for getting the DNS host suffix, and modifies the related GraphQL schema. The changes focus on adapting the app interception process for local clusters and adding functionality to retrieve DNS host information.

Sequence Diagram

sequenceDiagram
    participant CLI
    participant Server
    participant LocalCluster
    CLI->>Server: core_interceptAppOnLocalCluster(clusterName, ipAddr, ...)
    Server->>LocalCluster: Intercept app
    LocalCluster-->>Server: Interception result
    Server-->>CLI: Return result

Loading

File-Level Changes

Change	Details	Files
Updated app interception mutation	Renamed mutation from 'Core_interceptApp' to 'Core_interceptAppOnLocalCluster' Replaced 'deviceName' parameter with 'clusterName' and 'ipAddr' Updated the corresponding GraphQL query in the schema	src/apps/auth/server/gql/cli-queries.ts gql-queries-generator/doc/queries.graphql
Added new query for retrieving DNS host suffix	Implemented 'cli_getDNSHostSuffix' query Added corresponding GraphQL query 'authCli_getDNSHostSuffix' in the schema	src/apps/auth/server/gql/cli-queries.ts gql-queries-generator/doc/queries.graphql

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @nxtcoder36 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (complexity): Consider maintaining both device-based and cluster-based interception functions or creating a more generic function to handle both cases.

The changes to cli_interceptApp (now cli_interceptAppOnLocalCluster) introduce additional complexity by shifting from a device-based to a cluster-based approach. While this may be necessary for the evolving architecture, consider the following suggestions to minimize complexity and maintain API clarity:

1. Keep both functions to ensure backwards compatibility:

cli_interceptApp: executor(
  gql`
    mutation Core_interceptApp(
      $portMappings: [Github__com___kloudlite___operator___apis___crds___v1__AppInterceptPortMappingsIn!]
      $intercept: Boolean!
      $deviceName: String!
      $appName: String!
      $envName: String!
    ) {
      core_interceptApp(
        portMappings: $portMappings
        intercept: $intercept
        deviceName: $deviceName
        appname: $appName
        envName: $envName
      )
    }
  `,
  {
    transformer: (data: any) => data.core_interceptApp,
    vars: (_: any) => {},
  }
),

cli_interceptAppOnLocalCluster: executor(
  gql`
    mutation Core_interceptAppOnLocalCluster(
      $portMappings: [Github__com___kloudlite___operator___apis___crds___v1__AppInterceptPortMappingsIn!]
      $intercept: Boolean!
      $clusterName: String!
      $ipAddr: String!
      $appName: String!
      $envName: String!
    ) {
      core_interceptAppOnLocalCluster(
        portMappings: $portMappings
        intercept: $intercept
        clusterName: $clusterName
        ipAddr: $ipAddr
        appname: $appName
        envName: $envName
      )
    }
  `,
  {
    transformer: (data: any) => data.core_interceptAppOnLocalCluster,
    vars: (_: any) => {},
  }
),

2. If possible, consider creating a more generic function that can handle both device and cluster-based interception:

cli_interceptApp: executor(
  gql`
    mutation Core_interceptApp(
      $portMappings: [Github__com___kloudlite___operator___apis___crds___v1__AppInterceptPortMappingsIn!]
      $intercept: Boolean!
      $target: InterceptTargetInput!
      $appName: String!
      $envName: String!
    ) {
      core_interceptApp(
        portMappings: $portMappings
        intercept: $intercept
        target: $target
        appname: $appName
        envName: $envName
      )
    }
  `,
  {
    transformer: (data: any) => data.core_interceptApp,
    vars: (_: any) => {},
  }
),

Where InterceptTargetInput is a new input type that can represent either a device or a cluster:

input InterceptTargetInput {
  deviceName: String
  clusterName: String
  ipAddr: String
}

This approach would provide flexibility while maintaining a single, more generic API.

Please provide more context on why this change was necessary and how it fits into the broader architecture. This information would help in understanding the rationale behind the current implementation and potentially lead to more tailored suggestions for reducing complexity.