-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli queries updated #295
cli queries updated #295
Conversation
Reviewer's Guide by SourceryThis pull request updates GraphQL queries related to BYOK (Bring Your Own Kubernetes) cluster management in the CLI. The changes modify the structure of the returned data for creating and listing BYOK clusters, adding and removing certain fields from the responses. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nxtcoder36 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Can you provide more context on the decision to remove the 'id' field from the create mutation response? Are there any potential impacts on existing code that might rely on this field?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -6630,6 +6630,7 @@ query authCli_listByokClusters($search: SearchCluster, $pagination: CursorPagina | |||
edges { | |||
cursor | |||
node { | |||
clusterToken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Exposing clusterToken in list query may pose a security risk
Consider the security implications of returning the clusterToken in a list query. This could potentially expose sensitive information if not handled properly. Evaluate whether this token needs to be included in the response and, if so, ensure proper access controls are in place.
* cli queries updated * changes in kl cli * minor change
* cli queries updated * changes in kl cli * minor change
* cli queries updated * changes in kl cli * minor change
Summary by Sourcery
Update CLI queries to include 'displayName' in the 'authCli_createClusterReference' mutation and 'clusterToken' in the 'authCli_listByokClusters' query.
Enhancements: