Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli queries updated #295

Merged
merged 3 commits into from
Sep 17, 2024
Merged

cli queries updated #295

merged 3 commits into from
Sep 17, 2024

Conversation

nxtcoder36
Copy link
Contributor

@nxtcoder36 nxtcoder36 commented Sep 17, 2024

Summary by Sourcery

Update CLI queries to include 'displayName' in the 'authCli_createClusterReference' mutation and 'clusterToken' in the 'authCli_listByokClusters' query.

Enhancements:

  • Add 'displayName' to the 'authCli_createClusterReference' mutation response.
  • Include 'clusterToken' in the 'authCli_listByokClusters' query response.

Copy link

sourcery-ai bot commented Sep 17, 2024

Reviewer's Guide by Sourcery

This pull request updates GraphQL queries related to BYOK (Bring Your Own Kubernetes) cluster management in the CLI. The changes modify the structure of the returned data for creating and listing BYOK clusters, adding and removing certain fields from the responses.

File-Level Changes

Change Details Files
Updated the createBYOKCluster mutation response
  • Removed 'id' field from the response
  • Added 'displayName' field to the response
  • Retained 'clusterToken' and 'metadata.name' fields
gql-queries-generator/doc/queries.graphql
src/apps/auth/server/gql/cli-queries.ts
Modified the listByokClusters query response
  • Added 'clusterToken' field to the response for each cluster
  • Retained 'displayName', 'id', and 'metadata' fields
gql-queries-generator/doc/queries.graphql
src/apps/auth/server/gql/cli-queries.ts

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nxtcoder36 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Can you provide more context on the decision to remove the 'id' field from the create mutation response? Are there any potential impacts on existing code that might rely on this field?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -6630,6 +6630,7 @@ query authCli_listByokClusters($search: SearchCluster, $pagination: CursorPagina
edges {
cursor
node {
clusterToken
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 issue (security): Exposing clusterToken in list query may pose a security risk

Consider the security implications of returning the clusterToken in a list query. This could potentially expose sensitive information if not handled properly. Evaluate whether this token needs to be included in the response and, if so, ensure proper access controls are in place.

@nxtCoder19 nxtCoder19 removed their assignment Sep 17, 2024
@nxtcoder36 nxtcoder36 merged commit a952b10 into release-v1.0.5 Sep 17, 2024
5 checks passed
@nxtcoder36 nxtcoder36 deleted the ref/cli-cmds branch September 17, 2024 08:55
abdheshnayak pushed a commit that referenced this pull request Oct 28, 2024
* cli queries updated

* changes in kl cli

* minor change
tulsiojha pushed a commit that referenced this pull request Nov 1, 2024
* cli queries updated

* changes in kl cli

* minor change
abdheshnayak pushed a commit that referenced this pull request Nov 5, 2024
* cli queries updated

* changes in kl cli

* minor change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants