-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated graphql/generator packages #277
Conversation
Reviewer's Guide by SourceryThis pull request updates the GraphQL schema in the
These changes aim to improve code readability and maintainability without changing the underlying GraphQL schema or its functionality. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tulsiojha - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
}; | ||
}; | ||
|
||
export type ConsoleListImportedManagedResourcesQuery = { core_listImportedManagedResources?: { totalCount: number, edges: Array<{ cursor: string, node: { accountName: string, creationTime: any, displayName: string, environmentName: string, id: string, markedForDeletion?: boolean, name: string, recordVersion: number, updateTime: any, createdBy: { userEmail: string, userId: string, userName: string }, lastUpdatedBy: { userEmail: string, userId: string, userName: string }, managedResourceRef: { id: string, name: string, namespace: string }, secretRef: { name: string, namespace?: string }, syncStatus: { action: Github__Com___Kloudlite___Api___Pkg___Types__SyncAction, error?: string, lastSyncedAt?: any, recordVersion: number, state: Github__Com___Kloudlite___Api___Pkg___Types__SyncState, syncScheduledAt?: any }, managedResource?: { accountName: string, apiVersion?: string, clusterName: string, creationTime: any, displayName: string, enabled?: boolean, environmentName: string, id: string, isImported: boolean, kind?: string, managedServiceName: string, markedForDeletion?: boolean, mresRef: string, recordVersion: number, updateTime: any, metadata?: { annotations?: any, creationTimestamp: any, deletionTimestamp?: any, generation: number, labels?: any, name: string, namespace?: string }, spec: { resourceNamePrefix?: string, resourceTemplate: { apiVersion: string, kind: string, spec?: any, msvcRef: { apiVersion?: string, kind?: string, name: string, namespace: string } } }, status?: { checks?: any, isReady: boolean, lastReadyGeneration?: number, lastReconcileTime?: any, checkList?: Array<{ debug?: boolean, description?: string, hide?: boolean, name: string, title: string }>, message?: { RawMessage?: any }, resources?: Array<{ apiVersion: string, kind: string, name: string, namespace: string }> }, syncedOutputSecretRef?: { apiVersion?: string, data?: any, immutable?: boolean, kind?: string, stringData?: any, type?: K8s__Io___Api___Core___V1__SecretType } } } }>, pageInfo: { endCursor?: string, hasNextPage?: boolean, hasPrevPage?: boolean, startCursor?: string } } }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider adding strategic line breaks to improve readability of complex types
While the more compact style may be intentional, some of the more complex type definitions (like ConsoleListImportedManagedResourcesQuery) could benefit from strategic line breaks. This would maintain the overall compact style while improving readability for the most complex parts. For example, you might consider breaking after each major nested object or array.
export type ConsoleListImportedManagedResourcesQuery = {
core_listImportedManagedResources?: {
totalCount: number,
edges: Array<{
cursor: string,
node: {
accountName: string,
creationTime: any,
displayName: string,
environmentName: string,
id: string,
markedForDeletion?: boolean,
name: string,
recordVersion: number,
updateTime: any,
createdBy: { userEmail: string, userId: string, userName: string },
lastUpdatedBy: { userEmail: string, userId: string, userName: string },
managedResourceRef: { id: string, name: string, namespace: string },
secretRef: { name: string, namespace?: string },
syncStatus: {
action: Github__Com___Kloudlite___Api___Pkg___Types__SyncAction,
error?: string,
lastSyncedAt?: any,
recordVersion: number,
state: Github__Com___Kloudlite___Api___Pkg___Types__SyncState,
syncScheduledAt?: any
},
managedResource?: {
accountName: string,
apiVersion?: string,
clusterName: string,
creationTime: any,
displayName: string,
enabled?: boolean,
environmentName: string,
id: string,
isImported: boolean,
kind?: string,
managedServiceName: string,
markedForDeletion?: boolean,
mresRef: string,
recordVersion: number,
updateTime: any,
metadata?: {
annotations?: any,
creationTimestamp: any,
deletionTimestamp?: any,
generation: number,
labels?: any,
name: string,
namespace?: string
},
spec: {
resourceNamePrefix?: string,
resourceTemplate: {
apiVersion: string,
kind: string,
spec?: any,
msvcRef: {
apiVersion?: string,
kind?: string,
name: string,
namespace: string
}
}
},
status?: {
checks?: any,
isReady: boolean,
lastReadyGeneration?: number,
lastReconcileTime?: any,
checkList?: Array<{
debug?: boolean,
description?: string,
hide?: boolean,
name: string,
title: string
}>,
message?: { RawMessage?: any },
resources?: Array<{
apiVersion: string,
kind: string,
name: string,
namespace: string
}>
},
syncedOutputSecretRef?: {
apiVersion?: string,
data?: any,
immutable?: boolean,
kind?: string,
stringData?: any,
type?: K8s__Io___Api___Core___V1__SecretType
}
}
}
}>,
pageInfo: {
endCursor?: string,
hasNextPage?: boolean,
hasPrevPage?: boolean,
startCursor?: string
}
}
};
updated graphql/generator packages
updated graphql/generator packages
updated graphql/generator packages
Summary by Sourcery
Reformat the GraphQL type definitions to enhance code readability by adjusting line breaks and indentation without altering the functionality.
Enhancements: