Impl/app image pull #151
Merged
Impl/app image pull #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compute and scaling
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @nxtcoder36 - I've reviewed your changes and they look great!
General suggestions:
- Consider adding a tooltip or help text to further clarify the implications of the 'Always' setting for users unfamiliar with image pull policies.
- Review the consistency of terminology and user interface elements across the application to ensure this change aligns with overall design and messaging.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
abdheshnayak
approved these changes
Mar 15, 2024
abdheshnayak
pushed a commit
that referenced
this pull request
Oct 28, 2024
* app image pull in progress * image pull policy check box added, modifications in app setting for compute and scaling * label changed for image pull policy in app creation and app settings page
tulsiojha
pushed a commit
that referenced
this pull request
Nov 1, 2024
* app image pull in progress * image pull policy check box added, modifications in app setting for compute and scaling * label changed for image pull policy in app creation and app settings page
abdheshnayak
pushed a commit
that referenced
this pull request
Nov 5, 2024
* app image pull in progress * image pull policy check box added, modifications in app setting for compute and scaling * label changed for image pull policy in app creation and app settings page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.