fix: trx from raw transaction type

[pedrxlz]

Summary by CodeRabbit

• New Features
  • Enhanced transaction processing for multiple contract types in TRX implementation, improving flexibility and robustness.
• Bug Fixes
  • Improved error handling for missing transaction contracts.
• Tests
  • Expanded test cases to include validation for TriggerSmartContract transactions, ensuring accurate parsing and expected value returns.

[coderabbitai]

Walkthrough

The pull request introduces enhancements to the TRX implementation in the Tron module of the Kos SDK. It improves transaction contract processing by implementing a more robust mechanism for unpacking various contract types, including TransferContract, TransferAssetContract, and TriggerSmartContract. The logic for extracting transaction signatures has been streamlined, and new test cases have been added to ensure accurate functionality across the newly supported contract types.

Changes

Files	Change Summary
packages/kos-sdk/src/chains/tron/mod.rs	Enhanced transaction contract processing to support multiple contract types. Simplified signature extraction and added a test case for TriggerSmartContract. Included import for ContractType.

Possibly related PRs

• Feat/transaction from raw #65: The changes in this PR also modify the packages/kos-sdk/src/chains/tron/mod.rs file, specifically enhancing transaction handling by introducing a new function for processing raw transaction data, which aligns with the main PR's focus on improving transaction contract handling.

Poem

🐇 In the land of code, where transactions flow,
A new way to handle, we proudly bestow.
Contracts of many, now dance in delight,
With signatures simple, the future is bright!
Hops of success, let’s cheer and rejoice,
For changes in Tron, we all raise our voice! 🎉

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a91f04e and 05cb18e.

Files selected for processing (1)

• packages/kos-sdk/src/chains/tron/mod.rs (5 hunks)

Additional comments not posted (5)

packages/kos-sdk/src/chains/tron/mod.rs (5)

17-17: LGTM!

The import statement is valid and necessary for the changes made in the extract_address_from_contract function.

---

419-422: LGTM!

The code change is valid and improves error handling by explicitly checking for the presence of a contract in the transaction's raw data.

---

434-434: LGTM!

The code change is valid and simplifies the extraction of the transaction signature by directly accessing the signature field from the tx object.

---

445-471: LGTM!

The new extract_address_from_contract function is well-structured and improves the flexibility of transaction processing by handling multiple contract types. It correctly unpacks the contract parameters and extracts the owner_address for each contract type using a match statement.

---

710-720: LGTM!

The new test case test_tx_from_raw for the TriggerSmartContract transaction type is valid and ensures that the tx_from_raw function can handle this transaction type correctly. It checks for the expected values of chain, sender, and hash, providing good coverage.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[brunocampos-ssa]

@coderabbitai resume

[coderabbitai]

Actions performed

Reviews resumed.

[brunocampos-ssa]

@coderabbitai full review

[coderabbitai]

Actions performed

Full review triggered.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

packages/kos-sdk/src/chains/tron/mod.rs (1)

419-453: Excellent work on enhancing the contract type handling and improving error handling!

The changes made to the tx_from_raw function significantly improve its flexibility and robustness by supporting multiple contract types and handling missing contracts gracefully.

Extracting the sender address based on the contract type is a clean and effective approach.

Consider adding more test cases to cover the newly supported contract types, such as TransferAssetContract and TriggerSmartContract, to ensure their proper functionality.

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8f032e7 and fdb294e.

Files selected for processing (1)

• packages/kos-sdk/src/chains/tron/mod.rs (4 hunks)

Additional comments not posted (2)

packages/kos-sdk/src/chains/tron/mod.rs (2)

463-463: Simplified signature extraction logic.

Directly accessing the signature field from the tx object and mapping it to hex::encode is a concise and readable way to extract the signature.

---

711-721: Great job adding a test case for the TriggerSmartContract transaction type!

The new test case test_tx_from_raw thoroughly verifies that the tx_from_raw function can accurately parse a TriggerSmartContract transaction and return a Transaction struct with the expected values for chain, sender, and hash.

This test case enhances the test coverage and ensures the proper functionality of the newly supported contract type.