[KLC-1122] Review and Improve KDA Token Hook Implementations #13
+24
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to rename functions related to KDA NFT name and URI length to more general names, reflecting a broader use case. The changes are applied across multiple files to ensure consistency. The most important changes include updates to function pointers, trait implementations, and import objects.
Function renaming:
c-api/src/capi_vm_hook_pointers.rs
: Renamedget_kda_nft_name_length_func_ptr
andget_kda_nft_uri_length_func_ptr
toget_kda_name_length_func_ptr
andget_kda_uri_length_func_ptr
respectively.c-api/src/capi_vm_hooks.rs
: Updated function names in theVMHooks
implementation fromget_kda_nft_name_length
andget_kda_nft_uri_length
toget_kda_name_length
andget_kda_uri_length
.Import object updates:
vm-executor-wasmer/src/wasmer_imports.rs
: Modified the import functions to reflect the new namesget_kda_name_length
andget_kda_uri_length
. [1] [2]Trait and implementation updates:
vm-executor/src/vm_hooks.rs
: Updated theVMHooks
trait and its default implementation to use the new function namesget_kda_name_length
andget_kda_uri_length
. [1] [2]