Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KLC-1122] Review and Improve KDA Token Hook Implementations #13

Open
wants to merge 3 commits into
base: klever
Choose a base branch
from

Conversation

nickgs1337
Copy link
Contributor

@nickgs1337 nickgs1337 commented Jan 10, 2025

This pull request includes changes to rename functions related to KDA NFT name and URI length to more general names, reflecting a broader use case. The changes are applied across multiple files to ensure consistency. The most important changes include updates to function pointers, trait implementations, and import objects.

Function renaming:

  • c-api/src/capi_vm_hook_pointers.rs: Renamed get_kda_nft_name_length_func_ptr and get_kda_nft_uri_length_func_ptr to get_kda_name_length_func_ptr and get_kda_uri_length_func_ptr respectively.
  • c-api/src/capi_vm_hooks.rs: Updated function names in the VMHooks implementation from get_kda_nft_name_length and get_kda_nft_uri_length to get_kda_name_length and get_kda_uri_length.

Import object updates:

Trait and implementation updates:

  • vm-executor/src/vm_hooks.rs: Updated the VMHooks trait and its default implementation to use the new function names get_kda_name_length and get_kda_uri_length. [1] [2]

@nickgs1337 nickgs1337 marked this pull request as ready for review January 14, 2025 20:07
Beroni
Beroni previously approved these changes Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants