Save 1 API call by re-using existing_events for removeCopiedEvents

klausfl · Sep 1, 2021 · 88be2c7 · 88be2c7
1 parent c96361e
commit 88be2c7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/calendar.py b/src/calendar.py
@@ -26,9 +26,9 @@ def __init__(self, calendarId, googleService):
         self.googleService = googleService
 
     def copyAllEventsFrom(self, otherCalendar, period: DatePeriod, copySensibleData, colorId, skipMatching):
-        self.removeCopiedEvents(period)
         events = otherCalendar.getEvents(period)
         existing_events = self.getEvents(period)
+        self.removeCopiedEvents(existing_events)
 
         for event in events:
             if not skipMatching or not any(start_and_end_equal(event, e) for e in existing_events):
@@ -41,9 +41,9 @@ def getEvents(self, period: DatePeriod):
         events = events_result.get('items', [])
         return events
 
-    def removeCopiedEvents(self, period: DatePeriod):
+    def removeCopiedEvents(self, events):
         eventsToRemove = list(
-            filter(lambda event: COPIED_EVENT_LEADING_TEXT in event.get('summary', ''), self.getEvents(period)))
+            filter(lambda event: COPIED_EVENT_LEADING_TEXT in event.get('summary', ''), events))
         for event in eventsToRemove:
             self.deleteEvent(event.get("id"))