-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for MH-1823 with resoldered Wifi module #205
Open
aoe1
wants to merge
47
commits into
klausahrenberg:master
Choose a base branch
from
aoe1:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Info about the changes in this version
line breaks in DP list
Info about fork
undo
Not my binary
Not my binary
Added a firmware file that works for me (MH-1820 with ESP8266 soldered instead of WBR3)
Some clarification
…hedulesMode from MH-1823
Disable scheduleMode if byteScheduleMode is NOT_DEFINED (otherwise temp updates won't go through)
current build without schedulesMode dependency
Clarification on version check and MCU name
TempUnit = 0x13, SensorInOut = 0x12, Fahrenheit = 0x25, FahrenheitFloor = 0x66, CompensateMain = 0x23, CompensateFloor = 0x67, Slewing = 0x68, PowerOnOffWhenLocked = 0x69
Great work, Alexandr! |
…tBeca into klausahrenberg-master
(including 1.20n upstream changes)
Set MH-1823 as default (keeps config) Fix bug not reporting Lock status in MQTT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Klaus,
I assume this will not make it into the main repository easily considering the MH-1823 is a WBR3 (RTL8720) thermostat and only accessible to WThermostatBeca when resoldered with an ESP8266 but maybe the DPs will help someone. As for MQTT push, I realized this and updating the desired temperature only worked when schedulesMode was off but there are still some extraneous push statements in the code. I disabled that logic in case schedulesModeByte was NOT_SUPPORTED but there.
Cheers,
Alexandr ([email protected])