Add a flag to control whether save the config to local as cache.

kklldog · Mar 21, 2024 · 5449eda · 5449eda
1 parent 50c05bb
commit 5449eda
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 5 deletions.
diff --git a/AgileConfig.Client/ConfigClient.cs b/AgileConfig.Client/ConfigClient.cs
@@ -795,6 +795,11 @@ await _WebsocketClient.SendAsync(new ArraySegment<byte>(data, 0, data.Length), W
 
         private void WriteConfigsToLocal(string configContent)
         {
+            if (!_options.CacheEnabled)
+            {
+                return;
+            }
+
             try
             {
                 if (string.IsNullOrEmpty(configContent))

diff --git a/AgileConfig.Client/ConfigClientOptions.cs b/AgileConfig.Client/ConfigClientOptions.cs
@@ -24,6 +24,8 @@ public class ConfigClientOptions
 
         public int HttpTimeout { get; set; } = 100;
 
+        public bool CacheEnabled { get; set; } = true;
+
         public string CacheDirectory { get; set; }
         /// <summary>
         /// 缓存加密
@@ -135,12 +137,14 @@ public static ConfigClientOptions FromConfiguration(IConfiguration config)
             var timeout = config["AgileConfig:httpTimeout"];
             var cacheDir = config["AgileConfig:cache:directory"] ?? "";
             var cacheEncrypt = config.GetValue("AgileConfig:cache:config_encrypt", false);
+            var cacheEnabled = config.GetValue("AgileConfig:cache:enabled", true);
             options.Name = name;
             options.Tag = tag;
             options.AppId = appId;
             options.Secret = secret;
             options.Nodes = serverNodes;
             options.ENV = string.IsNullOrEmpty(env) ? "" : env.ToUpper();
+            options.CacheEnabled = cacheEnabled;
             options.CacheDirectory = cacheDir;
             options.ConfigCacheEncrypt = cacheEncrypt;
             if (int.TryParse(timeout, out int iTimeout))
@@ -234,14 +238,21 @@ private static string TryGetIdFromLocal(string cacheDir, string appId)
 
         private static void WriteIdToLocal(string cacheDir, string appId, string serviceId)
         {
-            if (!string.IsNullOrWhiteSpace(cacheDir) && !Directory.Exists(cacheDir))
+            try
             {
-                Directory.CreateDirectory(cacheDir);
-            }
+                if (!string.IsNullOrWhiteSpace(cacheDir) && !Directory.Exists(cacheDir))
+                {
+                    Directory.CreateDirectory(cacheDir);
+                }
 
-            string idFileName = Path.Combine(cacheDir, $"{appId}.agileconfig.client.serviceid");
+                string idFileName = Path.Combine(cacheDir, $"{appId}.agileconfig.client.serviceid");
 
-            File.WriteAllText(idFileName, serviceId);
+                File.WriteAllText(idFileName, serviceId);
+            }
+            catch (Exception e)
+            {
+                DefaultConsoleLogger.LogError(e, "Can not save serviceId to local");
+            }
         }
 
         private static ILogger _consoleLogger;

diff --git a/AgileConfig.Client/RegisterCenter/DiscoveryService.cs b/AgileConfig.Client/RegisterCenter/DiscoveryService.cs
@@ -206,6 +206,10 @@ private void EnsureCacheDir()
 
         private void WriteServiceInfosToLocal(string content)
         {
+            if (!_options.CacheEnabled)
+            {
+                return;
+            }
             try
             {
                 if (string.IsNullOrEmpty(content))
-Original file line number
+Diff line change
@@ Expand Up @@
             private void WriteConfigsToLocal(string configContent)
             {
+                if (!_options.CacheEnabled)
+                {
+                    return;
+                }
                 try
                 {
                     if (string.IsNullOrEmpty(configContent))
@@ Expand Down @@