Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add treesitter code actions #221

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add treesitter code actions #221

wants to merge 10 commits into from

Conversation

joshpetit
Copy link

@joshpetit joshpetit commented May 22, 2023 •
edited
Loading

kkharji
kkharji reviewed May 22, 2023
View reviewed changes
Copy link
Owner

@kkharji kkharji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly amazing and full of possibilities 💪🏼. Great work

lua/xbase/init.lua Outdated Show resolved Hide resolved
lua/xbase/init.lua Outdated Show resolved Hide resolved
lua/xbase/init.lua Outdated Show resolved Hide resolved
lua/xbase/init.lua Outdated Show resolved Hide resolved
lua/xbase/treesitter.lua Show resolved Hide resolved
lua/xbase/treesitter.lua Outdated Show resolved Hide resolved
@joshpetit joshpetit requested a review from kkharji May 23, 2023 22:46
kkharji
kkharji reviewed May 24, 2023
View reviewed changes
Copy link
Owner

@kkharji kkharji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing. Write in the README.md a description of this awesome new feature

lua/xbase/null_ls.lua Show resolved Hide resolved
lua/xbase/treesitter.lua Outdated Show resolved Hide resolved
kkharji
kkharji reviewed May 24, 2023
View reviewed changes
lua/xbase/treesitter.lua Outdated Show resolved Hide resolved
@joshpetit
Copy link
Author

Ok cool, last thing that's needed still is figuring out why the code actions are only running one time. I have no clue what may be causing this lol.

@joshpetit
Copy link
Author

The developer of null ls mentioned that cspell would be a good way to use null-ls in a plugin to be used by others.

We could try refactoring this PR to look like that if you think that's valuable.

@kkharji
Copy link
Owner

kkharji commented May 29, 2023

Yes, it makes sense to me.

@tomoakley
Copy link

Hi, what's the status of this PR now that null-ls is archived?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkharji kkharji kkharji left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshpetit @kkharji @tomoakley