-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some non-byteclean drivers #807
Open
kk7ds
wants to merge
7
commits into
master
Choose a base branch
from
bitwise-cleanups
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 8, 2023
-
bitwise: Support string-to-char[] in some cases
This makes bitwise allow converting strings to char[] without encoding if the string can be encoded purely as ASCII. Drivers should really be pre-encoding strings, which this will also natively allow, but a LOT of drivers will need to change for this to be a hard requirement.
Configuration menu - View commit details
-
Copy full SHA for 779bfa9 - Browse repository at this point
Copy the full SHA 779bfa9View commit details -
boblov_x3plus: Fix raw bytestring handling
This driver also hasn't been converted or tested for python3. However, it is pretty simple so this change also includes prospective byte-clean conversions which may make it just work.
Configuration menu - View commit details
-
Copy full SHA for 825bcb6 - Browse repository at this point
Copy the full SHA 825bcb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0711952 - Browse repository at this point
Copy the full SHA 0711952View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c25e1f - Browse repository at this point
Copy the full SHA 1c25e1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7126df3 - Browse repository at this point
Copy the full SHA 7126df3View commit details -
Configuration menu - View commit details
-
Copy full SHA for bca5bec - Browse repository at this point
Copy the full SHA bca5becView commit details -
vx8: Fix raw bytestring handling (et al)
This also fixes some other python3isms that apparently never got addressed originally.
Configuration menu - View commit details
-
Copy full SHA for 330720b - Browse repository at this point
Copy the full SHA 330720bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.