Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run tests on all platforms #4

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

run tests on all platforms #4

wants to merge 3 commits into from

Conversation

kd7lxl
Copy link
Contributor

@kd7lxl kd7lxl commented Aug 23, 2021

No description provided.

pyserial \
tox
- run: rm chirp/drivers/generic_xml.py
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather just remove it from the tree than have the test stuff silently behave differently here versus locally. I have a commit on the py3 branch to do it, I'll pull it over.

@kk7ds
Copy link
Owner

kk7ds commented Aug 23, 2021

Running the tests on the master branch on windows requires using the old test runner because the setup.py is specific for py2exe. Never tried to run them on macos, but the same problem may exist with the legacy py2app stuff. Windows tests on the py3 branch should work the same as linux because that's all modernized.

@kd7lxl
Copy link
Contributor Author

kd7lxl commented Aug 23, 2021

Running the tests on the master branch on windows requires using the old test runner

How do you do that? Use python tests/run_tests.py instead of tox?

@kk7ds
Copy link
Owner

kk7ds commented Aug 23, 2021

How do you do that? Use python tests/run_tests.py instead of tox?

Yup, or run_tests.bat in windows. In either case, you have to have all the deps installed manually of course. Personally, I'm not sure it's worth running the tests on the other platforms in master, as I'm not sure it's ever caught anything platform-specific (and we don't have good enough coverage anyway). Running them on py3 should be easy though, and if we're going to catch up that branch and keep it close, then we'd get some tangential coverage that way.

@kk7ds
Copy link
Owner

kk7ds commented Aug 23, 2021

Actually, I've got most of the build stuff pulled out at this point anyway, so give me some time this week and I'll see if I can extricate the rest and make setup.py more normal in the tree. That'll make it possible for people to use tox on windows anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants