Ensure eval call knows its line numbers etc #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @kjvarga to have some of these pending PRs merged asap. ☝🏼 |
|
Hi there! Any news? ping @kjvarga |
|
@olleolleolle hello! can you please rebase your branch? Thank you! |
Use #each_key, add a separating newline, and meaningfully name heredoc markers.
olleolleolle
force-pushed
the
add-line-number-to-eval-call
branch
from
08d1a43 to
4d93f64
Compare
|
@n-rodriguez Now rebased! |
|
I guess the CI configuration has to be unconfigured in the Settings page of this project, so that there are no requirements on CircleCI having finalized. |
|
@olleolleolle @n-rodriguez I've removed the CircleCI Webhook from settings so it shouldn't show up in the status checks. But looks like we might have to push an empty commit to clear out the errored job. |
|
@olleolleolle @kjvarga Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds binding and line number information to an eval'd piece of code.