fix test

kjozsa · Jun 18, 2024 · 86d8bad · 86d8bad
1 parent 9d5d158
commit 86d8bad
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ava/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java b/...ava/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java
@@ -2010,7 +2010,7 @@ public void validateApproval(JsonCommand command, Long loanId) {
             }
 
             BigDecimal approvedLoanAmount = command.bigDecimalValueOfParameterNamed(LoanApiConstants.approvedLoanAmountParameterName);
-            if (approvedLoanAmount == null) {
+            if (approvedLoanAmount != null) {
                 compareApprovedToProposedPrincipal(loan, approvedLoanAmount);
             }
 

diff --git a/...t/portfolio/loanaccount/service/LoanApplicationWritePlatformServiceJpaRepositoryImpl.java b/...t/portfolio/loanaccount/service/LoanApplicationWritePlatformServiceJpaRepositoryImpl.java
@@ -566,7 +566,7 @@ public CommandProcessingResult approveApplication(final Long loanId, final JsonC
 
         if (!changes.isEmpty()) {
             final String noteText = command.stringValueOfParameterNamed("note");
-            createNote(noteText, loan).ifPresent(note -> changes.put("note", note));
+            createNote(noteText, loan).ifPresent(note -> changes.put("note", noteText));
             businessEventNotifierService.notifyPostBusinessEvent(new LoanApprovedBusinessEvent(loan));
         }