Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Update env.py #285

Closed
wants to merge 2 commits into from
Closed

Update env.py #285

wants to merge 2 commits into from

Conversation

kjaymiller
Copy link
Owner

fixes #284

With this being generated by the environment file I would like to propose another potential fix to ignore the issue either with:

1 - manually with a # ruff: noqa appended to the top of the file.
or
2 - We can also modify the `extend-exclude to include ALL files in the migrations (and not just the version info)

1 doesn't solve the issue long term either as if we ever need to regenerate the file the problem would appear again (which is the concern currently)

2 is a little better but this fix is harmless.

I do wonder if this is something that could be fixed on the alembic end (unless they specifically chose not to fix it)

@pamelafox
Copy link
Collaborator

Here's my PR where I previously made style changes to env.py:
miguelgrinberg/Flask-Migrate#504 (comment)

As you can see, my suggestion to fully match the style of isort wasn't taken up on, so I would say that yes, they specifically choose not to fix it.

That's why I ended up doing an exclude, since I really quickly ran into style issues when I updated the migrations.

So am a fan of #2

@kjaymiller kjaymiller closed this Nov 30, 2023
@kjaymiller kjaymiller deleted the kjaymiller-add-trailing-comma branch November 30, 2023 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adds trailing comma to migrations env.py file
2 participants