Feat/footer #20
Merged
Feat/footer #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
itnoj15
commented
May 1, 2024
itnoj15
commented
- Populated publication data
- Added a footer
jhw123
requested changes
May 1, 2024
| 'Junho Myung', | ||
| 'Minsun Kim', | ||
| 'Hyunseung Lim', | ||
| 'Yoonsu Kim', |
There was a problem hiding this comment.
Perhaps, we should have worked on the members data first...
There was a problem hiding this comment.
Plus, I think it is better to restrict the type of authors to either Members and string, not both. If we go with Members, we can keep the single source of truth policy, but we need to change the current Member class to handle external members. If we go with string, it is easier but the code will be susceptible to typos...
There was a problem hiding this comment.
Yes, I agree! I think we need to discuss this problem as well..
There was a problem hiding this comment.
I wonder if there is an API somewhere that can automatically populate these fields
jhw123
approved these changes
May 30, 2024
jhw123
added a commit
that referenced
this pull request
Sep 5, 2024
* Basic project setup (#1) * 🧑💻 switch to yarnv4 from npm * 🧑💻 add prettier * 🌱 add data classes and placeholder pages * 👷 add a CI github workflow * 💄 add theme * ✨ add Providers component * ✨ impl NavBar * 💄 change global font to Noto Sans * 💄 add more themes * 🏷️ update Publication structure * ✨ add URL component * ✨ add PublicationCard component * ✨ update publications page * 🎨 improve theme structure * 💄 add global focus-visible style * 💄 update URL component style * 💄 update gap sizes in publications page * 🎨 add Global styles & Section component * 🐛 replace incorrect data * 🔀 define style constants replacing the use of `ThemeProvider` (#4) * Minor global design updates (#5) * 💄 specify scroll behavior * 💄 NavBar sticks to the top * 💄 define a const for the `NavBar` height * Make CI check run everytime (#6) * 👷 run CI check on all branches * 📦 fix the semantic version of prettier * 👷 prevent using npx instead of yarn * Adding dev tools (#7) * 🌱 add PR template * 👷 add a workflow for reviewing * Change Readme and website metadata (#10) * 🌱 add alex to the member list * 📝 update readme * Update metadata in layout component * 💚 fix style issue --------- Co-authored-by: Hyoungwook Jin <[email protected]> * Adding auto assign owner (#11) - 👷 add auto assign owner workflow * Minor refactoring (#8) * 📦 add lodash * ♻️ refactor some code * Edit page metadata (#14) * Initial implementation of News page (#15) * ✏️ Edit page metadata * Implemented the first version of News page * Fix bugs * Style fix * Modify variable name, variable type and image paths * Remove unnecessary modal codes * Finish `PublicationCard` and Implement `Filter` (#13) * ♻️ refactor author rendering in `PublicationCard` * ✨ add topic tags to `PublicationCard` * ♻️ update a variable name from `ResearchTopic` to `ResearchTopics` * ➕ add react-icons * ✨ implement filtering functionality in publications page * ✨ add award tags to `PublicationCard` * 🐛 remove YearTypes * 🐛 check if URL exists * 💡 remove some comments * ♻️ use `Member.fullname` getter * 🚚 move PulbicationCard.tsx to a separate folder * ✨ allow adding non-KIXLAB members to authors * ✨ attach links to paper titles + minor design updates * Add course data and Modify page code (#12) * Add course data and Modify page code * Resolve type error * Resolve style check * Resolve minor issues * Restore original files * Update import method for 'lodash' * Delete package-lock.json * Complement Publications page (#18) * ✨ sort publication list * ✨ support PDF links in component * 🤡 add mock data * ♻️ refactor state management for filtering with `useRouter` * 💬 update filter name for publication type * 🥅 fix error * Feat/homepage (#19) * ✨ Add Initial Hero Section * ✨ Initial news and themes section * ✨ Initial Research Theme Section * 🎨 Refactor sections into indiv. functions * ✨ Responsive typography to hero section * 🎨 Reorganize hero section * 💄 Align youtube videos in Media section * 👷 Install Husky, lint-staged for pre-commit type/style checks * 🐛 Fix style issues * 🐛 Prettier fix format * Complement Publications page (#18) * ✨ sort publication list * ✨ support PDF links in component * 🤡 add mock data * ♻️ refactor state management for filtering with `useRouter` * 💬 update filter name for publication type * 🥅 fix error * 🐛 Fix image source * 🔥 Remove example image * 🔥 Remove commented lines; merge unnecessary lines * 🔥 Remove Prettier changes * ♻️ Refactor homepage into smaller files, readjust youtube embeded size * 🎨 Fix style issues * 🎨 Removed comment and moved const declarations out of `HeroSection` --------- Co-authored-by: Yumin Cho <[email protected]> * Feat/footer (#20) * Populate publication data * Upload HCI, SOC logo images * Update theme.ts * Add a Footer * Update Footer.tsx * Update publications.ts * Update Footer.tsx * ⚡️ Combine FooterText1 and FooterText2 * 🎨 Style fix --------- Co-authored-by: Alex Tio <[email protected]> * ⬆️ Bump next from 14.0.4 to 14.1.1 (#22) Bumps [next](https://github.com/vercel/next.js) from 14.0.4 to 14.1.1. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.0.4...v14.1.1) --- updated-dependencies: - dependency-name: next dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Feat/responsive design (#21) * Hotfix/publications (#24) * 💄 Fix inconsistent icons & duplicate buttons * 🐛 Add loading.tsx file and solve build issues * Publication/fix formatting (#25) * 🐛 Add loading.tsx file and solve build issues (#23) * 🐛 Remove `navigator` which is only available in client-side code * 🐛 Move `react-icons` to `dependencies` from `devDependencies` * 🔧 Add `forceConsistentCasingInFileNames` * ⬇️ Downgrade `react` and `react-icons` to match existing version * 🔧 Set experimental cpus to 1 to mitigate OOM issues on Netlify * 🔧 Replace 'nodeLinker: pnp` with `nodeLinker: node-modules` which Netlify requires (it doesn't support Yarn PnP) * 🤡 **** style check * 🚚 Convert hero image to webp format * ⬆️ Bump braces in the npm_and_yarn group across 1 directory (#26) Bumps the npm_and_yarn group with 1 update in the / directory: [braces](https://github.com/micromatch/braces). Updates `braces` from 3.0.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Responsive design for news page (#27) * Add responsive design for News page * Add news data * Update README.md (#29) * Update README.md * styling update * Fix styling issues in News page (#33) * Use NewsCard component in News Section in main page (#34) * Fix styling issues in News page * Use NewsCard component in News Section in main page --------- Co-authored-by: Alex Tio <[email protected]> * 🐛 Fix font size mismatch (#31) * 🐛 Fix font size mismatch * 🐛 Change hero text justification * Add new hero-image (#35) * feat/footer (#37) * Update footer to be responsive * De-commit package-lock.json and yarn.lock * feat/{max width margins, research themes section, button links, layout fixes} (#32) * ✨ Fix avatars to feature members who last published * 🎨 Remove Member class; replace with IMember interface * ✨ Make research themes card clickable and link to publications page * ✨ 1-2 line description for each is topic is now the number of publications with this tag * Change box color * 🐛 Ensure member avatars are 36x36px * 💄 Customize emojis for each research card * 🐛 Fix research themes author algorithm * 💄 Increase padding between Hero text area and the top and bottom * ✨ Add button links * 🐛 Adjust navbar to go down all the way * ✨ Add max width margins. Ensure header obeys max width margins * 🐛 Make header sticky * 🐛 Add 'use client' to Client components * 🐛 Fix bug where gray background was not extending the full viewport width; change max width to 1400px * 🐛 Fix news page misalignment * 🐛 Commit missing SNS icons * 💄 Add spacing between video and title * Feat/footer2 (#38) * Update footer to be responsive * De-commit package-lock.json and yarn.lock * Update Footer.tsx * feat/publication (#36) * Add navigation side bar * Update navigation bar * Add yarn.lock and package-lock.json * Delete package-lock.json * Refactor Navigation Bar (SideBar) into component * 🎨 Make SideBar more modular (WIP) * 🐛 Fix bug where contents would overflow on small screens * 💄 Change spacing after pub. section title * 🐛 Rename one entry to avoid duplicate 'keys' * 🐛 Fix type error --------- Co-authored-by: Alex Tio <[email protected]> Co-authored-by: Alex Tio <[email protected]> * Bugfix/publication-page (#39) * 🐛 Fix publication page misalignment * 🐛 Fix bug where an overflowing string inside the filter box could shift the entire page layout * 💄 Tweak responsive right padding of publication page * 💄 Capitalize string in filter box and filter list * 🐛 Fix bug where filtering by topic would cause the layout to shift * 🐛 Fix Navbar's background to be opaque white across the page * Fix some bugs on sidebar * 🐛 Fix layout shift when switching between different filter options * Update page.tsx (add useMemo, fix publicationList) * 🏷️ Update CReHate and FLASK publications * 🔥 Remove CenteredContainer * 🏷️ Change 'human-ai-interaction' `ResearchTopics` key to 'human-AI interaction' * Update publication page.tsx and SideBar.tsx * Update SideContainer css style --------- Co-authored-by: 김찬영 <[email protected]> * People2 (#40) * 🍱 Add member images * ✨ Initial People Page * 🍱 updated Daeun's new photo * 🎨 1. Used image component for SpecialThanksImage 2. Adding divider between the sections 3. Using Section component 4. Using pre-defined font style for consistency * 🎨 1. Changed to named export in AlumnCard 2. Corrected Seoyoung’s name and “RIT” for Jiangnan * 💄 1:1 ratio of images across all dimensions * 🐛 Fix ResearchThemesSection avatar src * 🐛 Fix Yokyung's email * 🎨 Adding sidebar component to people page * 🎨 Adding sidebar component to people page * Adding sidebar component to people page * 🎨 Adding sidebar component to people page * 🐛 Fix Sidebar formatting for People page * 🐛 Fix visual bug where the right Sidebar link is not correctly activating * 🐛 Adjust param values of IntersectionObserver in publications page * 🎨 Separate alumni members into their own data structure * 🎨 Refactor Observer code into Sidebar component * 🎨 Remove classes; change data structures to use plain JSON objects * 🎨 Add types to data arrays; change Videos to plain JSON objects * 📝 Add summer 2024 interns * ♻️ Replace a with Link; crop hero image * 🍱 Add back ms theses * 🎨 Change default exports to named exports * 🍱 Add CHI, ICLR 2024 paper awards * 🎨 Use lodash to capitalize words * 🎨 rename `interface <Component>Props` -> `interface Props` * 🎨 Put back in Classes * 🎨 Combine alumni data structure with members; push member filtering operations from `people/page.tsx` into server-rendered `members.ts` * 🎨 Push filtering operations out of `publications/page.tsx` and into `publication.ts` --------- Co-authored-by: Alex Tio <[email protected]> Co-authored-by: Alex Tio <[email protected]> * 🍱 Update Daeheon, Hyehun, and Seulgi's statuses (#42) * optimize/homepage (#41) * ⚡️ Use YoutubeEmbed instead of iframe * 🐛 remove "--cache" from `yarn lint` command * 🔧 Explicitly allow robot crawlers for SEO * ⚡️ Use dynamic imports for each section in homepage --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Yumin Cho <[email protected]> Co-authored-by: Alex Tio <[email protected]> Co-authored-by: DaEun Choi <[email protected]> Co-authored-by: chanyoung <[email protected]> Co-authored-by: Alex Tio <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: 김찬영 <[email protected]> Co-authored-by: shahnozayadgar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.