Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Work on People Page #16

Closed
wants to merge 12 commits into from
Closed

Initial Work on People Page #16

wants to merge 12 commits into from

Conversation

shahnozayadgar
Copy link
Contributor

@shahnozayadgar shahnozayadgar commented Feb 29, 2024

  • - Include all members with images, names, email address, MS thesis (PhD students), Universities (interns+visiting researchers)
  • Include Alumni and Special thanks
Screenshot 2024-02-29 at 3 20 44 PM

@github-actions github-actions bot requested a review from yumincho February 29, 2024 06:22
@shahnozayadgar shahnozayadgar self-assigned this Feb 29, 2024
@github-actions github-actions bot requested a review from itnoj15 February 29, 2024 06:26
@shahnozayadgar shahnozayadgar requested review from jhw123 and removed request for itnoj15 and yumincho February 29, 2024 06:26
@shahnozayadgar shahnozayadgar changed the title Feat/people Initial Work on People Page Feb 29, 2024
@github-actions github-actions bot requested a review from alextio February 29, 2024 08:37
alextio
alextio previously approved these changes Feb 29, 2024
@alextio alextio self-requested a review February 29, 2024 09:01
@alextio alextio dismissed their stale review March 1, 2024 00:37

Code is still bugged

Copy link
Contributor

@alextio alextio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noza's field in members.ts is missing email and career field causing errors in checks. Please add those.

shahnozayadgarova: {
firstName: 'Shahnoza',
lastName: 'Yadgarova',
img: 'noza.jpeg',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing email, career field here

@jhw123
Copy link
Member

jhw123 commented Mar 6, 2024

Could you fix the type error first?

@shahnozayadgar shahnozayadgar requested a review from alextio March 12, 2024 06:44
alextio added 2 commits March 21, 2024 19:17
This reverts commit d541c7c, reversing
changes made to 4d611db.
@alextio
Copy link
Contributor

alextio commented Mar 21, 2024

Too many file changes. Best to restart this PR with a clean branch.

@alextio alextio closed this Mar 21, 2024
@jhw123 jhw123 deleted the feat/people branch June 6, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants