Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading release APK in Github release instead of standalone APK. #4115

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Nov 28, 2024

Fixes #4114

  • To resolve the publishing issue on IzzyOnDroid, we are now uploading the Release APK(with org.kiwix.kiwixmobile package name) to the GitHub release, so that IzzyOnDroid can retrieve the APK and upload it to their platform easily.
  • Generated dummy release APKs along with the dummy bundle to have them readily available if needed. For example, in the current scenario, we need to manually generate the release APKs and upload them to the 3.12.0 GitHub release so that IzzyOnDroid can fetch and update the application on their platform. See it is uploaded the Release APKs https://github.com/kiwix/kiwix-android/actions/runs/12063880435

* To resolve the publishing issue on `IzzyOnDroid`, we are now uploading the `Release` APK(with `org.kiwix.kiwixmobile` package name) to the GitHub release, allowing `IzzyOnDroid` to easily retrieve the APK and upload it to their platform.
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft November 28, 2024 06:13
… readily available if needed.

* For example, in the current scenario, we need to manually generate the release APKs and upload them to the 3.12.0 GitHub release so that IzzyOnDroid can fetch and update the application on their platform.
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.10%. Comparing base (2cd2e15) to head (7ced396).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4115      +/-   ##
============================================
+ Coverage     58.89%   59.10%   +0.21%     
- Complexity     1569     1582      +13     
============================================
  Files           316      316              
  Lines         13431    13431              
  Branches       1706     1706              
============================================
+ Hits           7910     7939      +29     
+ Misses         4385     4361      -24     
+ Partials       1136     1131       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review November 28, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants