remove pid anv jvmName tags as it bloats influx (they should really b…

…e values, not tags)
kiwipower · Nov 12, 2018 · 20f2f8a · 20f2f8a
1 parent 15a14db
commit 20f2f8a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/pom.xml b/pom.xml
@@ -4,7 +4,7 @@
 
     <groupId>com.etsy</groupId>
     <artifactId>statsd-jvm-profiler</artifactId>
-    <version>2.1.1-SNAPSHOT</version>
+    <version>2.1.2-SNAPSHOT</version>
     <packaging>jar</packaging>
 
     <name>statsd-jvm-profiler</name>

diff --git a/src/main/java/com/etsy/statsd/profiler/util/TagUtil.java b/src/main/java/com/etsy/statsd/profiler/util/TagUtil.java
@@ -25,13 +25,13 @@ private TagUtil() { }
     public static Map<String, String> getGlobalTags(Map<String, String> tags) {
         // Add the jvm name, pid, hostname as tags to help identify different processes
         final String jvmName = ManagementFactory.getRuntimeMXBean().getName();
-        tags.put(JVM_NAME_TAG, jvmName);
+//        tags.put(JVM_NAME_TAG, jvmName);
         int atIndex = jvmName.indexOf("@");
         if (atIndex > 0) {
-            tags.put(PID_TAG, jvmName.substring(0, atIndex));
+//            tags.put(PID_TAG, jvmName.substring(0, atIndex));
             tags.put(HOSTNAME_TAG, jvmName.substring(atIndex + 1));
         } else {
-            tags.put(PID_TAG, UNKNOWN);
+//            tags.put(PID_TAG, UNKNOWN);
             tags.put(HOSTNAME_TAG, UNKNOWN);
         }
 

diff --git a/src/test/java/com/etsy/statsd/profiler/util/TagUtilTest.java b/src/test/java/com/etsy/statsd/profiler/util/TagUtilTest.java
@@ -53,9 +53,9 @@ public void testGetGlobalTags() {
         Map<String, String> globalTags = new HashMap<>();
         TagUtil.getGlobalTags(globalTags);
         Set<String> expectedKeys = new HashSet<>();
-        expectedKeys.add(TagUtil.PID_TAG);
+//        expectedKeys.add(TagUtil.PID_TAG);
         expectedKeys.add(TagUtil.HOSTNAME_TAG);
-        expectedKeys.add(TagUtil.JVM_NAME_TAG);
+//        expectedKeys.add(TagUtil.JVM_NAME_TAG);
 
         assertEquals(expectedKeys, globalTags.keySet());
     }