-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is a recipe for mysql-connector-python #2974
base: develop
Are you sure you want to change the base?
Conversation
Thanks for contributing.
|
Thanks for addressing the linting issue, now the test updated recipes builds fail with:
I think it's because you're downloading the java connector. |
Co-authored-by: Andre Miras <[email protected]>
version = '8.3.0' | ||
url = ( | ||
f'https://dev.mysql.com/get/Downloads/' | ||
f'Connector-J/mysql-connector-j-{version}.tar.gz' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops remove that line, we will get there I promise 😅
I've messed up the URL too, the prefix with "Connector-J" should be "Connector-Python" as well.
For example a full working URL would be, but we need to use the {version}
template obviously
https://dev.mysql.com/get/Downloads/Connector-Python/mysql-connector-python-8.3.0-src.tar.gz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂no problem we will fix it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not far from getting this merged, would you mind looking this up? We simply need to get that URL right.
Don't forget to check the linter locally before pushing too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can i test it locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the linting, running flake8 should be enough.
python -m venv venv
venv/bin/pip install flake8
venv/bin/flake8 pythonforandroid/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The url
still needs to be fixed
url = ( | ||
f"https://downloads.mysql.com/archives/get/p/29/file/" | ||
f"mysql-connector-python-py{version}-1ubuntu23.10_amd64.deb" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is giving a 404
wget https://downloads.mysql.com/archives/get/p/29/file/mysql-connector-python-py8.3.0-1ubuntu23.10_amd64.deb
Why didn't you keep it as :
https://dev.mysql.com/get/Downloads/Connector-Python/mysql-connector-python-{version}-src.tar.gz
Or with line split:
url = (
"https://dev.mysql.com/get/Downloads/Connector-Python/"
f"mysql-connector-python-{version}-src.tar.gz"
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i change the link to url = (
"https://dev.mysql.com/get/Downloads/Connector-Python/"
f"mysql-connector-python-{version}-src.tar.gz"
). Thank you! i home this time will work!
Hello,
This is a mysql-connector-python recipe!