Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add --android-target-sdk-version arg (defaults to android_api) #2686

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

build: add --android-target-sdk-version arg (defaults to android_api) #2686

wants to merge 2 commits into from

Commits on Oct 12, 2022

  1. build: add --android-target-sdk-version arg (defaults to android_api) 

    Currently p4a has a variable named `android_api` (set by e.g. buildozer via the `app.android.api` config key).
In `AndroidManifest.xml`, both `compileSdkVersion` and `targetSdkVersion` are set to `android_api`.

This PR allows setting the targetSdkVersion and compileSdkVersion independently, by adding a `--android-target-sdk-version` build arg.

`compileSdkVersion` is a compilation setting used by e.g. the NDK at build-time,
while `targetSdkVersion` is just a field to set in the manifest, only used at runtime (mainly in the Java world).
(see e.g. https://stackoverflow.com/a/26694276 )
    @SomberNight
    SomberNight committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    7443087 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. fix tests

    @SomberNight
    SomberNight committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    aff85a6 View commit details
    Browse the repository at this point in the history