Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Email Address Fixed in the Readme.md #1722

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Support Email Address Fixed in the Readme.md #1722

merged 2 commits into from
Oct 18, 2023

Conversation

saharbat00l
Copy link
Contributor

@saharbat00l saharbat00l commented Oct 17, 2023

Issue #1716 : resolved

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @seharbat00l !

I've left a review, let me know what are your thoughts about it 😀

(We will need to fix the same issue over all the Kivy's Github repos 😅)

README.md Outdated
@@ -168,8 +168,7 @@ config, along with the environment variables that would override them.

If you need assistance, you can ask for help on our mailing list:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about having a "refactor" of the support readme section?

Maybe something like:

If you need assistance, you can ask for help on one of our support channels:
- [Kivy Users Google Group](https://groups.google.com/group/kivy-users)
- [Discord](https://chat.kivy.org)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can do that. You want to have the same clickable text like "Kivy Users Google Group" for Discord? Am i right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is it required only on this repo or others too? If yes then which ones? You can create issue for them and I'll refactor them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make another PR with this Discord refactor on this repo. Kindly approve that PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is it required only on this repo or others too? If yes then which ones? You can create issue for them and I'll refactor them.

Yes, it's needed also on other repos of the kivy organization. I will open the issues and assign them to you. 😀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is it required only on this repo or others too? If yes then which ones? You can create issue for them and I'll refactor them.

Ping me on the following issues, so I can assign it to you:

@saharbat00l
Copy link
Contributor Author

I've made the commit after refactoring support section. You can checkk

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants