Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization for modern JS. decluttered global javascript memory and … #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Keon-Kim-0
Copy link

@Keon-Kim-0 Keon-Kim-0 commented Nov 25, 2020

optimization for modern JS. decluttered global javascript memory and optimized reverb/impulseResponse efficiency.

@Keon-Kim-0
Copy link
Author

Keon-Kim-0 commented Nov 25, 2020

Hey I absolutely loved your library, I used it extensively with my react/redux/sql/express music production application (website) with it. But reverb was not as efficient/fast as I needed it to be for the computational load my app produces(100s of notes at ones using synth), causing stutters and buffer lagging. I then attempted to improve the library's time/space complexity by optimizing mathematical calculations, specifically for reverb function (impulseResponse) and switching out var to modern declarations to free up global memory. And I'am happy to say that I was able to bring significant improvements on the performence. I would love it if you can review it and compare for your self, I left all the original comments. Much love, keep up the great work! I genuinely thought there was no other all in one package audiocontext.api library better than yours. I really hope you keep this repo going! Kudos to you my man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants