-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSRF protection on OAuth pages #440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aumetra
force-pushed
the
aumetra/csrf-protection
branch
from
December 7, 2023 21:32
301cf8b
to
f08d417
Compare
Thinking of using a keyed BLAKE2/BLAKE3 hash here. Fast and simple. BLAKE3 is superior in terms of raw speed (according to benchmarks and (IIRC) available implementations in Rust), but I don't think that the performance difference will really show in this case, since the values we work on are small. |
Flake lock file updates: • Updated input 'devenv': 'github:cachix/devenv/a7c4dd8f4eb1f98a6b8f04bf08364954e1e73e4f' (2023-11-28) → 'github:cachix/devenv/e681a99ffe2d2882f413a5d771129223c838ddce' (2023-12-14) • Updated input 'nixpkgs': 'github:nixos/nixpkgs/2c7f3c0fb7c08a0814627611d9d7d45ab6d75335' (2023-12-04) → 'github:nixos/nixpkgs/a9bf124c46ef298113270b1f84a164865987a91c' (2023-12-11) • Updated input 'rust-overlay': 'github:oxalica/rust-overlay/670ae43e7e5e7cf90b873cea596941d2e24e9c2c' (2023-12-07) → 'github:oxalica/rust-overlay/d7aaf97c7c5ea7b4198ef85d3d66b3dfe5c6ce57' (2023-12-15)
aumetra
force-pushed
the
aumetra/csrf-protection
branch
from
December 15, 2023 22:09
92a3107
to
12b2706
Compare
aumetra
force-pushed
the
aumetra/csrf-protection
branch
from
December 16, 2023 11:44
2f2977c
to
2aa42a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #431
This PR adds:
lib/cursiv
)