Skip to content

Commit

Permalink
fix nightly warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
aumetra committed Aug 28, 2024
1 parent 59f8a7d commit 6d15f9b
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 17 deletions.
12 changes: 6 additions & 6 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions crates/kitsune-cache/src/redis.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ where
let key = self.compute_key(key);

debug!(%key, "Deleting cache entry");
self.redis_conn.del(key).await?;
let () = self.redis_conn.del(key).await?;

Ok(())
}
Expand All @@ -78,7 +78,8 @@ where
let serialised = sonic_rs::to_string(value)?;

debug!(%key, ttl = ?self.ttl, "Setting cache entry");
self.redis_conn
let () = self
.redis_conn
.set(
key,
serialised,
Expand Down
3 changes: 2 additions & 1 deletion crates/kitsune-oidc/src/state/store/redis.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ impl Store for Redis {

async fn set(&self, key: &str, value: LoginState) -> Result<()> {
let raw_value = sonic_rs::to_string(&value)?;
self.pool
let () = self
.pool

Check warning on line 33 in crates/kitsune-oidc/src/state/store/redis.rs

View check run for this annotation

Codecov / codecov/patch

crates/kitsune-oidc/src/state/store/redis.rs#L32-L33

Added lines #L32 - L33 were not covered by tests
.set(Self::format_key(key), raw_value, None, None, false)
.await?;

Expand Down
13 changes: 7 additions & 6 deletions lib/athena/src/redis/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ where
.duration_since(Timestamp::UNIX_EPOCH)
.as_seconds_f64();

client
let () = client

Check warning on line 108 in lib/athena/src/redis/mod.rs

View check run for this annotation

Codecov / codecov/patch

lib/athena/src/redis/mod.rs#L108

Added line #L108 was not covered by tests
.zadd(
self.scheduled_queue_name.as_str(),
None,
Expand All @@ -116,7 +116,7 @@ where
)
.await?;
} else {
client
let () = client
.xadd(
self.queue_name.as_str(),
false,
Expand Down Expand Up @@ -241,14 +241,14 @@ where
let client = self.redis_pool.next();
let pipeline = client.pipeline();

pipeline
let () = pipeline
.xack(
self.queue_name.as_str(),
self.consumer_group.as_str(),
stream_id.as_str(),
)
.await?;
pipeline
let () = pipeline
.xdel(self.queue_name.as_str(), &[stream_id])
.await?;

Expand Down Expand Up @@ -279,7 +279,7 @@ where
Outcome::Success => true, // Execution succeeded, we don't need the context anymore
};

pipeline.last().await?;
let () = pipeline.last().await?;

if remove_context {
self.context_repository
Expand All @@ -297,7 +297,8 @@ where
.get::<String>()
.expect("[Bug] Not a string in the context");

self.redis_pool
let () = self
.redis_pool

Check warning on line 301 in lib/athena/src/redis/mod.rs

View check run for this annotation

Codecov / codecov/patch

lib/athena/src/redis/mod.rs#L300-L301

Added lines #L300 - L301 were not covered by tests
.xclaim(
self.queue_name.as_str(),
self.consumer_group.as_str(),
Expand Down
2 changes: 1 addition & 1 deletion lib/athena/src/redis/scheduled.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ pub struct ScheduledJobActor {
impl ScheduledJobActor {
async fn run(&mut self) -> Result<()> {
let client = self.redis_pool.next();
SCHEDULE_SCRIPT
let () = SCHEDULE_SCRIPT
.evalsha_with_reload(
client,
(self.queue_name.as_str(), self.scheduled_queue_name.as_str()),
Expand Down
2 changes: 1 addition & 1 deletion lib/tower-stop-using-brave/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ license = "MIT OR Apache-2.0"

[dependencies]
either = "1.13.0"
futures-test = "0.3.30"
http = "1.1.0"
regex = "1.10.6"
tower-layer = "0.3.3"
tower-service = "0.3.3"

[dev-dependencies]
futures-test = "0.3.30"
tower = { version = "0.5.0", default-features = false, features = ["util"] }

[lints]
Expand Down

0 comments on commit 6d15f9b

Please sign in to comment.