Only create Matomo Tracker instance if confirm_tracking cookie has be… #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisagli
requested changes
Dec 9, 2024
| useEffect(() => { | ||
| if (confirmTracking) { | ||
| if (confirmTracking && __CLIENT__ ) { |
There was a problem hiding this comment.
@fredvd useEffect hooks only run on the client (see the implementation of the useClient hook! https://github.com/plone/volto/blob/0987c96dbc4597b8ab36009af4e4bfa125f123ec/packages/volto/src/hooks/client/useClient.js#L5) so this is redundant.
Suggested change
| if (confirmTracking && __CLIENT__ ) { | |
| if (confirmTracking) { |
| disableCookies: false, | ||
| setSecureCookie: true, | ||
| }, | ||
| }); | ||
| tracker.trackPageView(); | ||
| } | ||
| }, [tracker, confirmTracking]); |
There was a problem hiding this comment.
The hook should not have tracker as a dependency. That means it will run again any time tracker changes, which means it will run after every render since the hook itself sets tracker.
There was a problem hiding this comment.
(This is also why the linter is complaining.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en set (#35)