Remove sim/global-variables.d.ts

The sim no longer uses any global variables, so this can and should be
removed.

`server/global-variables` has also been cleaned up, since I'm working
on this.

.eslintrc-no-types.json

@@ -14,8 +14,7 @@
     "tools/set-import/importer.js",
     "tools/set-import/sets",
     "tools/modlog/converter.js",
-    "server/global-variables.d.ts",
-    "sim/global-variables.d.ts"
+    "server/global-variables.d.ts"
  ],
   "env": {
     "es6": true,

config/formats.ts

@@ -1307,7 +1307,10 @@ export const Formats: FormatList = [
 			}
 			const customRules = this.format.customRules || [];
 			if (!customRules.includes('!obtainableabilities')) customRules.push('!obtainableabilities');
-			// const TeamValidator: new (format: string | Format) => TeamValidator = this.constructor as TeamValidator;
+
+			const TeamValidator: typeof import('../sim/team-validator').TeamValidator =
+				require('../sim/team-validator').TeamValidator;
+
 			const validator = new TeamValidator(dex.getFormat(`${this.format.id}@@@${customRules.join(',')}`));
 			const moves = set.moves;
 			set.moves = [ability.id];

server/chat-plugins/datasearch.ts

@@ -10,6 +10,7 @@
 
 import {QueryProcessManager} from '../../lib/process-manager';
 import {Utils} from '../../lib/utils';
+import {TeamValidator} from '../../sim/team-validator';
 
 interface DexOrGroup {
 	abilities: {[k: string]: boolean};
@@ -2423,7 +2424,6 @@ if (!PM.isParentProcess) {
 	global.Chat = require('../chat').Chat;
 	global.toID = Dex.toID;
 	Dex.includeData();
-	global.TeamValidator = require('../../sim/team-validator').TeamValidator;
 
 	// @ts-ignore
 	require('../../lib/repl').Repl.start('dexsearch', cmd => eval(cmd)); // eslint-disable-line no-eval

server/global-variables.d.ts

@@ -1,6 +1,5 @@
 import * as ChatType from './chat';
 import * as RoomsType from './rooms';
-import * as RoomlogsType from './roomlogs';
 import * as SocketsType from './sockets';
 import * as TeamValidatorAsyncType from './team-validator-async';
 import * as UsersType from './users';
@@ -9,13 +8,14 @@ import * as VerifierType from './verifier';
 import {ConfigType} from "../server/config-loader";
 
 import {IPTools as IPToolsType} from './ip-tools';
-import {LadderStore as LadderStoreType} from './ladders-remote';
 import {Ladders as LaddersType} from './ladders';
 import {LoginServer as LoginServerType} from './loginserver';
 import {Monitor as MonitorType} from './monitor';
 import {Punishments as PunishmentsType} from './punishments';
 import {Tournaments as TournamentsType} from './tournaments';
 
+import {Dex as DexType} from '../sim/dex';
+
 declare global {
 	namespace NodeJS {
 		interface Global {
@@ -30,7 +30,6 @@ declare global {
 			Punishments: any;
 			Rooms: any;
 			Sockets: any
-			TeamValidator: any;
 			TeamValidatorAsync: any;
 			Tournaments: any;
 			Users: any;
@@ -41,18 +40,17 @@ declare global {
 	}
 	const Config: ConfigType;
 	const Chat: typeof ChatType.Chat;
+	const Dex: typeof DexType;
 	const IPTools: typeof IPToolsType;
 	const Ladders: typeof LaddersType;
-	const LadderStoreT: typeof LadderStoreType;
 	const LoginServer: typeof LoginServerType;
 	const Monitor: typeof MonitorType;
 	const Punishments: typeof PunishmentsType;
+	const Rooms: typeof RoomsType.Rooms;
 	const Sockets: typeof SocketsType.Sockets;
 	const TeamValidatorAsync: typeof TeamValidatorAsyncType;
-	const Rooms: typeof RoomsType.Rooms;
 	const Tournaments: typeof TournamentsType;
-	const Roomlogs: typeof RoomlogsType.Roomlogs;
 	const Users: typeof UsersType.Users;
 	const Verifier: typeof VerifierType;
-	const toID: typeof Dex.toID;
+	const toID: typeof DexType.toID;
 }

server/ladders.ts

@@ -8,9 +8,9 @@
  * @license MIT
  */
 
-const LadderStore: typeof LadderStoreT = (typeof Config === 'object' && Config.remoteladder ?
-	require('./ladders-remote') :
-	require('./ladders-local')).LadderStore;
+const LadderStore: typeof import('./ladders-remote').LadderStore = (
+	typeof Config === 'object' && Config.remoteladder ? require('./ladders-remote') : require('./ladders-local')
+).LadderStore;
 
 const SECONDS = 1000;
 const PERIODIC_MATCH_INTERVAL = 60 * SECONDS;

server/team-validator-async.ts

@@ -8,6 +8,7 @@
  */
 
 import {crashlogger} from '../lib/crashlogger';
+import {TeamValidator} from '../sim/team-validator';
 
 export class TeamValidatorAsync {
 	format: Format;
@@ -68,15 +69,9 @@ export const PM = new QueryProcessManager<{
 	return '1' + packedTeam;
 });
 
-import {Repl} from '../lib/repl';
-import {TeamValidator} from '../sim/team-validator';
-import {Config} from './config-loader';
-
 if (!PM.isParentProcess) {
 	// This is a child process!
-	global.Config = Config;
-
-	global.TeamValidator = TeamValidator;
+	global.Config = require('./config-loader');
 
 	global.Monitor = {
 		crashlog(error: Error, source = 'A team validator process', details: AnyObject | null = null) {
@@ -97,7 +92,7 @@ if (!PM.isParentProcess) {
 	global.Dex = require('../sim/dex').Dex.includeData();
 
 	// eslint-disable-next-line no-eval
-	Repl.start(`team-validator-${process.pid}`, cmd => eval(cmd));
+	require('../lib/repl').Repl.start(`team-validator-${process.pid}`, (cmd: string) => eval(cmd));
 } else {
 	PM.spawn(global.Config ? Config.validatorprocesses : 1);
 }