Update Effect type signatures

- `affectsFainted` is a `PureEffect` property - `infiltrates` shouldn't exist on moves outside of OMs
kirliavc · May 1, 2020 · c4dd88a · c4dd88a
1 parent cbbd145
commit c4dd88a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/sim/global-types.ts b/sim/global-types.ts
@@ -763,7 +763,6 @@ interface EventMethods {
 
 interface EffectData {
 	name?: string;
-	affectsFainted?: boolean;
 	desc?: string;
 	duration?: number;
 	durationCallback?: (this: Battle, target: Pokemon, source: Pokemon, effect: Effect | null) => number;
@@ -793,6 +792,7 @@ interface BasicEffect extends EffectData {
 
 interface PureEffectData extends EffectData, PureEffectEventMethods, EventMethods {
 	noCopy?: boolean;
+	affectsFainted?: boolean;
 	counterMax?: number;
 }
 

diff --git a/test/sim/data.js b/test/sim/data.js
@@ -101,6 +101,7 @@ describe('Dex data', function () {
 			const entry = Movedex[moveid];
 			assert.equal(toID(entry.name), moveid, `Mismatched Move key "${moveid}" of "${entry.name}"`);
 			assert.equal(typeof entry.num, 'number', `Move ${entry.name} should have a number`);
+			assert.false(typeof entry.infiltrates, `Move ${entry.name} should not have an 'infiltrates' property (no real move has it)`);
 		}
 	});