Various fixes and changes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all, thank you for your work, it saved me quite some time! Since I implemented some fixes/changes, I thought I should contribute them back.
To get it compiling I needed to do some tweaks. 1. Is a fix for M1 compilation, 2. is a fix for XCode 14 sprintf deprecation.
It was only fixed in JDK 21 apparently (https://bugs.openjdk.org/browse/JDK-8299635) and I thought it is not worth to properly backport.
The third commit covers building for arm64 simulators and adding libpref builds. libpref seems to work, but not intensivly tested.
Feel free to take over whatever changes you want!