[Workload Management] QueryGroupService that orchestrates Resource Tracking & Cancellation #1
Conversation
| private final ClusterService clusterService; | ||
| private final ClusterSettings clusterSettings; | ||
| private final Settings settings; |
There was a problem hiding this comment.
We should only need settings defined for the feature in WorkloadManagementSettings class. Hence these member variables are unnecessary instead should only keep WorkloadManagementSettings instance.
There was a problem hiding this comment.
I'm having ClusterSettings & Settings only for setting up the NodeDuressTrackers, aer you proposing to move the node duress tracker into WorkloadManagementSettings class ?
There was a problem hiding this comment.
I think it makes sense to include NodeDuressTrackers setup in WorkloadManagementSettings instead of this class, what do you think ?
| private final QueryGroupResourceUsageTrackerService queryGroupUsageTracker; | ||
| private final TimeValue queryGroupServiceRunIntervalInMillis; | ||
| private volatile Scheduler.Cancellable scheduledFuture; | ||
| private final ThreadPool threadPool; |
There was a problem hiding this comment.
We should also have setting which controls whether the feature is enabled or not
| private final ClusterService clusterService; | ||
| private final ClusterSettings clusterSettings; | ||
| private final Settings settings; | ||
| private Set<QueryGroup> activeQueryGroups = new HashSet<>(); |
There was a problem hiding this comment.
This should init the query groups from the state metadata because in come cases metadata might have some querygroups since metadata is durable.
There was a problem hiding this comment.
Yes, I'm doing this in
protected Set<QueryGroup> getActiveQueryGroups() {
Map<String, QueryGroup> queryGroups = Metadata.builder(clusterService.state().metadata()).getQueryGroups();
return new HashSet<>(queryGroups.values());
}which is invoked from doRun()
kiranprakash154
force-pushed
the
kp/wlm-cancellation-1
branch
from
4e846e2 to
80dd918
Compare
Signed-off-by: Kiran Prakash <[email protected]>
Signed-off-by: Kiran Prakash <[email protected]
Signed-off-by: Kiran Prakash <[email protected]>
Signed-off-by: Kiran Prakash <[email protected]>
kiranprakash154
force-pushed
the
kp/queryGroup-Service-from-cancellation
branch
from
d8c31ee to
eb7ad77
Compare
Signed-off-by: Kiran Prakash <[email protected]>
Signed-off-by: Kiran Prakash <[email protected]>
Signed-off-by: Kiran Prakash <[email protected]>
Signed-off-by: Kiran Prakash <[email protected]>
Signed-off-by: Kiran Prakash <[email protected]>
kiranprakash154
changed the title
|
@kiranprakash154 Can we close this in favor of: opensearch-project#15925 |
Description
[Workload Management] QueryGroupService that orchestrates Resource Tracking & Cancellation
Related Issues
Resolves - opensearch-project#14883
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Kiran Prakash [email protected]Signed-off-by: Kiran Prakash [email protected]Signed-off-by: Kiran Prakash [email protected]