Ignore HTCP packets with invalid URI

kinkie · Jul 8, 2018 · 79b2379 · 79b2379
1 parent 5f7b22d
commit 79b2379
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/htcp.cc b/src/htcp.cc
@@ -749,9 +749,12 @@ htcpUnpackSpecifier(char *buf, int sz)
 
     s->request = HttpRequest::CreateFromUrlAndMethod(s->uri, method == Http::METHOD_NONE ? HttpRequestMethod(Http::METHOD_GET) : method);
 
-    if (s->request)
-        HTTPMSGLOCK(s->request);
+    if (!s->request) {
+        debugs(31, 3, "failed to create request. Invalid URI?");
+        return NULL;
+    }
 
+    HTTPMSGLOCK(s->request);
     return s;
 }