Skip to content
This repository has been archived by the owner on May 14, 2021. It is now read-only.

remove mismatch blockchain version check #367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions scripts/src/public/services/orders.ts
Original file line number Diff line number Diff line change
Expand Up @@ -201,13 +201,6 @@ async function createP2PExternalOrder(sender: User, senderDeviceId: string, jwt:
throw UserHasNoWallet(recipient.id);
}

// check wallet version matches
if (await WalletApplication.getBlockchainVersion(senderWallet.address) !==
await WalletApplication.getBlockchainVersion(recipientWallet.address)) {
logger().warn("failed p2p creation due to blockchain version mismatch");
throw UserHasNoWallet(recipient.id);
}

const order = db.ExternalOrder.new({
offerId: jwt.offer.id,
amount: jwt.offer.amount,
Expand Down
6 changes: 0 additions & 6 deletions scripts/src/public/services/orders.v1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,6 @@ async function createP2PExternalOrder(sender: User, jwt: ExternalPayToUserOrderJ
if (!recipientWallet) {
throw UserHasNoWallet(recipient.id);
}
// check wallet version matches
if (await WalletApplication.getBlockchainVersion(senderWallet.address) !==
await WalletApplication.getBlockchainVersion(recipientWallet.address)) {
logger().warn("failed p2p creation due to blockchain version mismatch on v1");
throw UserHasNoWallet(recipient.id);
}

const order = db.ExternalOrder.new({
offerId: jwt.offer.id,
Expand Down