This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
DP-540 - Unity CI Android POC - DO NOT MERGE #19
Open
yosriz
wants to merge
4
commits into
master
Choose a base branch
from
DP-540_unity_ci_android
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosriz
changed the title
DP-540 - unity ci android POC - DO NOT MERGE
DP-540 - Unity CI Android POC - DO NOT MERGE
Jul 23, 2019
Ronserruya
reviewed
Jul 23, 2019
Ronserruya
reviewed
Jul 23, 2019
Ronserruya
reviewed
Jul 23, 2019
Ronserruya
reviewed
Jul 23, 2019
Ronserruya
reviewed
Jul 23, 2019
Ronserruya
reviewed
Jul 23, 2019
Ronserruya
reviewed
Jul 23, 2019
Ronserruya
reviewed
Jul 23, 2019
Ronserruya
suggested changes
Jul 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments (Why do I need to add a comment here when I request changes? 💢 )
@Ronserruya please review |
Ronserruya
approved these changes
Jul 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a CI workflow for Android, based on Docker and Genymotion cloud device
This is based on a custom docker image based on existing unity docker file, the docker includes the correct unity version installed, android sdk and Genymotion "gmsaas" tool to interact with cloud device.
The CI script launch the docker image, launching a new device on cloud, connecting to the device via ADB, and then build and run tests on the cloud device.
References to the base docker image:
https://github.com/GabLeRoux/unity3d-ci-example
https://gitlab.com/gableroux/unity3d
TODO: