Added descriptions to SamplesForSampleKindAndHost model #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrossie
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Can you make sure to add links to our main doc - your other PR - to get the details/context about these metrics (maybe you already have it).
Regarding changing SamplesForSampleKindAndHost -> MetricsResult 👍 (You can do it in the same PR), and them go ahead and merge it.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
generated from commit 1104e1b
github-actions bot
pushed a commit
to reshmabidikar/slate
that referenced
this pull request
Jan 17, 2025
…TS-185 generated from commit 1104e1b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SamplesForSampleKindAndHosttoMetricResult(here and in the code). LMK if you would like me to open a PR for the code change.