Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 261 #11

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Fixes for 261 #11

merged 2 commits into from
Feb 4, 2020

Conversation

pierre
Copy link
Member

@pierre pierre commented Feb 1, 2020

See killbill/killbill-admin-ui#261:

After installing a new plugin the "configured instances" section does not refresh (and no indication that we should refresh) -> NOK

The UI doesn't have today an easy way to detect the installation is done on all nodes. I've added a little animation to prompt the user to refresh after a little bit.

The Upload Plugin screen with the custom URI needs some sane default values (what is a valid URI ?, what is a valid key ?). For the URI, it seems we only support scheme 'http', 'https', 'ws', or 'wss'.

See f6b7fe3.

I could not install the payment-test-plugin.

The payment-test-plugin doesn't respect our convention to use org.kill-bill.billing.plugin.java as the groupId for our plugins: https://github.com/killbill/killbill-payment-test-plugin/blob/cb7d1065a10ba838ff4c3c7937512183123ed2f7/pom.xml#L13 Thus, it won't work with our cloud directory.

I did try killbill/killbill-cloud@5eacd50 as a workaround, but it doesn't work with the KPM bundle due to internal validations (not worth pursuing IMHO, it's easier to fix the plugin and re-release):

Aborting installation for plugin_key payment-test: specified value org.kill-bill.billing.plugin.java for group_id does not match looked_up value org.killbill.billing.plugin.payment
./kpm/lib/kpm/base_installer.rb:261:in `validate_installation_arg!'
./kpm/lib/kpm/base_installer.rb:88:in `install_plugin'
./kpm/lib/kpm/tasks.rb:164:in `install_java_plugin'

Should we also support a file scheme -- or we enforce to have a webserver?

We cannot support a file scheme, as the installation process is run on each Kill Bill node (the URL is passed to each node, which will each download the plugin locally).

The previous version of Kaui (for 0.20.x) did support a file scheme but it only worked on a single node installation when Kill Bill and Kaui were running on the same machine. I've dropped support for this when migrating to the KPM bundle (sounded marginally useful - it's much easier to copy the jar then to upload it via Kaui when developing locally anyways).

Signed-off-by: Pierre-Alexandre Meyer <[email protected]>
@pierre pierre requested a review from sbrossie February 1, 2020 14:12
@pierre pierre merged commit 2ec0cc0 into master Feb 4, 2020
@pierre pierre deleted the fix-for-261 branch February 4, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants